Skip to content

Improve arc-green code theme (#21039) #21042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 1 commit into from
Sep 3, 2022
Merged

Improve arc-green code theme (#21039) #21042

6543 merged 1 commit into from
Sep 3, 2022
+105 −102

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Sep 3, 2022

Backport #21039

  • Increase contrasts overall
  • Add various missing theme classes
  • Ensure strings and constants are colored the same across languages

Before:
Screen Shot 2022-09-03 at 15 20 19
Screen Shot 2022-09-03 at 15 10 12

After:
Screen Shot 2022-09-03 at 15 19 31
image

@silverwind silverwind added this to the 1.17.2 milestone Sep 3, 2022
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 3, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 3, 2022
@delvh
Copy link
Member

delvh commented Sep 3, 2022

?
Why are you targeting main?

@lunny lunny changed the base branch from main to release/v1.17 September 3, 2022 15:42
@lunny lunny changed the base branch from release/v1.17 to main September 3, 2022 15:42
@delvh
Copy link
Member

delvh commented Sep 3, 2022

image
Now I'm even more confused…

@lunny
Copy link
Member

lunny commented Sep 3, 2022

image Now I'm even more confused…

I just want to help to change the base branch but found I cannot so I revert my change. Maybe @silverwind could rebase himself.

@6543 6543 changed the base branch from main to release/v1.17 September 3, 2022 16:24
@silverwind @6543
Improve arc-green code theme (go-gitea#21039)
b11dba0 
- Increase contrasts overall
- Add various missing theme classes
- Ensure strings and constants are colored the same across languages

Before:
<img width="575" alt="Screen Shot 2022-09-03 at 15 20 19" src="https://user-images.githubusercontent.com/115237/188272267-c3af3de0-a1d9-4a80-a3ab-278e9b04cb44.png">
<img width="705" alt="Screen Shot 2022-09-03 at 15 10 12" src="https://user-images.githubusercontent.com/115237/188272194-dc40ac7d-1629-44a0-a881-5f0922285195.png">

After:
<img width="579" alt="Screen Shot 2022-09-03 at 15 19 31" src="https://user-images.githubusercontent.com/115237/188272275-55b87bc7-1122-410f-9250-14cf9e973124.png">
<img width="703" alt="image" src="https://user-images.githubusercontent.com/115237/188272715-a5fcd180-c5dc-4303-8e77-de785d5e0937.png">
6543
6543 approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't noticed wrong targeting branch first as pull diff was right 😆

@6543
Copy link
Member

6543 commented Sep 3, 2022

fixed ;)

@silverwind
Copy link
Member Author

silverwind commented Sep 3, 2022

Thanks for the branch fixes, looks good now I think.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2022
@6543 6543 merged commit 3973ce3 into go-gitea:release/v1.17 Sep 3, 2022
@silverwind silverwind deleted the backport-21039 branch September 3, 2022 18:01
vanhoang1107 added a commit to vanhoang1107/gitea that referenced this pull request Oct 31, 2022
@vanhoang1107
Merge remote-tracking branch 'src/release/v1.17' into release/v1.17
d7bf1a9 
* src/release/v1.17: (26 commits)
  Fix reaction of issues (go-gitea#21185) (go-gitea#21196)
  Fix CSV diff for added/deleted files (go-gitea#21189) (go-gitea#21193)
  Fix pagination limit parameter problem (go-gitea#21111)
  Add MD5 back to template helper functions to avoid breaking (go-gitea#21102)
  Add changelog for v1.17.2 (go-gitea#21089)
  Fix sub folder in repository missing add file dropdown (go-gitea#21069) (go-gitea#21083)
  Fix hard-coded timeout and error panic in API archive download endpoint (go-gitea#20925) (go-gitea#21051)
  Fix delete user missed some comments (go-gitea#21067) (go-gitea#21068)
  Delete unreferenced packages when deleting a package version (go-gitea#20977) (go-gitea#21060)
  Redirect if user does not exist on admin pages (go-gitea#20981) (go-gitea#21059)
  Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (go-gitea#20902) (go-gitea#21058)
  Fix 500 on time in timeline API (go-gitea#21052) (go-gitea#21057)
  Fill the specified ref in webhook test payload (go-gitea#20961) (go-gitea#21055)
  Add another index for Action table on postgres (go-gitea#21033) (go-gitea#21054)
  fix broken insecureskipverify handling in rediss connection uris (go-gitea#20967) (go-gitea#21053)
  Add more checks in migration code (go-gitea#21011) (go-gitea#21050)
  Add Dev, Peer and Optional dependencies to npm PackageMetadataVersion (go-gitea#21017) (go-gitea#21044)
  Improve arc-green code theme (go-gitea#21039) (go-gitea#21042)
  Add down key check has tribute container (go-gitea#21016) (go-gitea#21038)
  Do not add links to Posters or Assignees with ID < 0 (go-gitea#20577) (go-gitea#21037)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.17.2

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @delvh @lunny @6543 @GiteaBot