Make support.threading_cleanup() stricter

[vstinner]

BPO	31234
Nosy	@vstinner
PRs	bpo-31234: threading_cleanup() now warns immediately #3138 bpo-31234: fork_wait tests now join threads #3139 bpo-31234: test_threading: fix ref cycle #3150 [3.6] bpo-31234: test_threading: fix ref cycle (#3150) #3152 [3.6] bpo-31234: fork_wait tests now join threads (#3139) #3187 bpo-31234: test_httpservers joins the server thread #3188 bpo-31234: test_threaded_import: fix test_side_effect_import() #3189 bpo-31234: Enhance test_thread.test_forkinthread() #3516 [3.6] bpo-31234: Enhance test_thread.test_forkinthread() (GH-3516) #3519 [2.7] bpo-31234: fork_wait tests now join threads (GH-3139) #3535 [3.6] bpo-31234: test_httpservers joins the server thread (GH-3188) #3536 [3.6] bpo-31234: test_threaded_import: fix test_side_effect_import() (GH-3189) #3537 bpo-31234: Fix dangling thread in test_ftp/poplib #3540 bpo-31234: Fix dangling thread in test_ftplib #3544 bpo-31234, socket.create_connection(): Fix ref cycle #3546 [3.6] bpo-31234, socket.create_connection(): Fix ref cycle (GH-3546) #3552 [3.6] bpo-31234: Fix dangling thread in test_ftp/poplib #3554 bpo-31234: Try to fix lock_tests warning #3557 bpo-31234: Join threads in tests #3572 bpo-31234: Join threads in test_hashlib #3573 bpo-31234: Add test.support.wait_threads_exit() #3578 bpo-31234: Join threads in test_threading #3579 bpo-31234: Join threads in test_queue #3586 bpo-31234: Add support.join_thread() helper #3587 [3.6] bpo-31234: Join threads in tests #3589 bpo-31234: Join timers in test_threading #3598 bpo-31234: test_multiprocessing: wait 30 seconds #3599 [3.6] bpo-31234: Add test.support.wait_threads_exit() (GH-3578) #7315 [2.7] bpo-31234: Join threads explicitly in tests #7406

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-10-17.20:39:07.246>
created_at = <Date 2017-08-18.17:12:58.276>
labels = ['3.7', 'tests']
title = 'Make support.threading_cleanup() stricter'
updated_at = <Date 2018-06-04.21:53:54.792>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2018-06-04.21:53:54.792>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2017-10-17.20:39:07.246>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2017-08-18.17:12:58.276>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 31234
keywords = ['patch']
message_count = 51.0
messages = ['300519', '300520', '300531', '300553', '300558', '300559', '300560', '300561', '300631', '300636', '300638', '300706', '300708', '300709', '301118', '301132', '301982', '302005', '302008', '302048', '302053', '302055', '302056', '302058', '302076', '302078', '302098', '302112', '302115', '302122', '302128', '302129', '302132', '302150', '302151', '302152', '302163', '302177', '302178', '302206', '302207', '302210', '302214', '302245', '302247', '302248', '302255', '302305', '304530', '318417', '318712']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = ['3138', '3139', '3150', '3152', '3187', '3188', '3189', '3516', '3519', '3535', '3536', '3537', '3540', '3544', '3546', '3552', '3554', '3557', '3572', '3573', '3578', '3579', '3586', '3587', '3589', '3598', '3599', '7315', '7406']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue31234'
versions = ['Python 3.7']

[vstinner]

Currently, support.threading_cleanup() waits 1 second before emitting a warning about threads running in the background. I propose to emit immediately the warning to be able to catch bugs quicker, bugs like bpo-31233 or bpo-30830.

The problem is that currently, 12 test files still leak threads:
---
12 tests altered the execution environment:
test_asyncio test_concurrent_futures test_fork1 test_httpservers
test_logging test_pydoc test_ssl test_thread test_threaded_import
test_threading test_wait3 test_xmlrpc
---

Since threading_cleanup() warnings now mark tests as failed, we should first fix these tests before being able to make support.threading_cleanup() stricter.

[vstinner]

test_fork1, test_wait3: #3139

[vstinner]

New changeset c99d41f by Victor Stinner in branch 'master':
bpo-31234: fork_wait tests now join threads (bpo-3139)
c99d41f

[vstinner]

test_threading: #3150

[vstinner]

test_pydoc: see bpo-31238.

[vstinner]

test_logging: see bpo-30830.

[vstinner]

New changeset 3d284c0 by Victor Stinner in branch 'master':
bpo-31234: test_threading: fix ref cycle (bpo-3150)
3d284c0

[vstinner]

New changeset b50e768 by Victor Stinner in branch '3.6':
bpo-31234: test_threading: fix ref cycle (bpo-3150) (bpo-3152)
b50e768

[vstinner]

test_xmlrpc: bpo-31247, "test_xmlrpc leaks dangling threads".

[vstinner]

test_concurrent_futures: bpo-31249, test_concurrent_futures leaks dangling threads.

[vstinner]

test_asyncio: bpo-31250, "test_asyncio leaks dangling threads".

[vstinner]

New changeset 5f20539 by Victor Stinner in branch '3.6':
bpo-31234: fork_wait tests now join threads (bpo-3139) (bpo-3187)
5f20539

[vstinner]

New changeset 830d7d2 by Victor Stinner in branch 'master':
bpo-31234: test_httpservers joins the server thread (bpo-3188)
830d7d2