bpo-40275: Use new test.support helper submodules in tests #21317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@vstinner pls take a look if you have free time, thanks. |
vstinner
approved these changes
Jul 6, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I cannot merge your PR, there is a merge conflict. Please fix the conflict, and ping me when it's done.
PyUnicode_EncodeDecimal and PyUnicode_TransformDecimalToASCII are deprecated since Python 3.3. But Py_DEPRECATED(3.3) was commented out.
It doesn't use PyUnicode_EncodeDecimal. It uses a private API instead.
Automerge-Triggered-By: @gvanrossum
* Clarify number of scopes * Indicate 3 or 4 Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
…21340) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
Member
Author
|
@vstinner ping : ) |
Member
Author
|
thanks, victor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use test helpers in the following test cases:
https://bugs.python.org/issue40275