wslsettings: fix OOBE text truncation at 200% text scaling

[benhillis]

Add text scaling factor to window resize calculation and make hero image height responsive to text scaling. Increase minimum window size for better accessibility. Fix MAS 1.4.4 compliance for OOBE dialog.

[Copilot]

Pull Request Overview

This PR adds text scaling support for accessibility to the OOBE (Out-of-Box Experience) window in WSL Settings. The changes ensure that when users increase text size through Windows accessibility settings, the OOBE window properly scales to accommodate the larger text while maintaining usability.

Key changes:

• Window automatically resizes in response to text scaling changes for accessibility
• Hero image height dynamically adjusts when text scaling is enabled to preserve content space
• Copyright headers updated to standardized format

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/windows/wslsettings/Windows/OOBEWindow.xaml.cs	Adds text scale factor event handling and updates ResizeWindow() to combine DPI and text scaling factors
src/windows/wslsettings/Windows/OOBEWindow.xaml	Increases minimum window size from 480x480 to 600x600 to accommodate scaled content
src/windows/wslsettings/Controls/OOBEContent.xaml.cs	Implements dynamic hero image height calculation based on text scaling factor
src/windows/wslsettings/Controls/OOBEContent.xaml	Updates margin to use centralized StaticResource for consistency
src/windows/wslsettings/LibWsl.cs	Removes trailing whitespace (code formatting cleanup)

[Copilot]

Creating a new UISettings instance in the constructor could be inefficient since UISettings is instantiated every time an OOBEContent control is created. Consider making this a static field or caching it, especially since the text scale factor is system-wide and doesn't need per-instance tracking.

Suggested change

	public OOBEContent()
	{
	this.InitializeComponent();
	// Adjust hero image height based on text scaling for better accessibility
	var settings = new UISettings();
	double textScaleFactor = settings.TextScaleFactor;
	private static readonly UISettings _uiSettings = new UISettings();
	public OOBEContent()
	{
	this.InitializeComponent();
	// Adjust hero image height based on text scaling for better accessibility
	double textScaleFactor = _uiSettings.TextScaleFactor;

[Copilot]

The text scale factor calculation in OOBEContent is only performed once in the constructor and won't update if the user changes text scaling while the window is open. Unlike OOBEWindow which subscribes to TextScaleFactorChanged events, this control has no mechanism to react to runtime accessibility changes. Consider subscribing to UISettings.TextScaleFactorChanged to update HeroImageHeight dynamically.

Suggested change

	public OOBEContent()
	{
	this.InitializeComponent();
	// Adjust hero image height based on text scaling for better accessibility
	var settings = new UISettings();
	double textScaleFactor = settings.TextScaleFactor;
	double baseImageHeight = 280.0;
	private UISettings _uiSettings;
	public OOBEContent()
	{
	this.InitializeComponent();
	// Adjust hero image height based on text scaling for better accessibility
	_uiSettings = new UISettings();
	UpdateHeroImageHeight(_uiSettings.TextScaleFactor);
	// Subscribe to text scale factor changes for runtime accessibility updates
	_uiSettings.TextScaleFactorChanged += UISettings_TextScaleFactorChanged;
	this.Unloaded += OOBEContent_Unloaded;
	}
	private void UISettings_TextScaleFactorChanged(UISettings sender, object args)
	{
	// Update hero image height when text scale changes
	if (_uiSettings != null)
	{
	UpdateHeroImageHeight(_uiSettings.TextScaleFactor);
	}
	}
	private void OOBEContent_Unloaded(object sender, RoutedEventArgs e)
	{
	if (_uiSettings != null)
	{
	_uiSettings.TextScaleFactorChanged -= UISettings_TextScaleFactorChanged;
	}
	this.Unloaded -= OOBEContent_Unloaded;
	}
	private void UpdateHeroImageHeight(double textScaleFactor)
	{
	double baseImageHeight = 280.0;

[Copilot]

The magic number 280.0 appears to match the default value in HeroImageHeightProperty (line 59), but this duplication could lead to maintenance issues. Consider using a named constant or referencing the dependency property's default value to maintain a single source of truth.

[Copilot]

The magic number 200.0 represents the minimum hero image height but is hardcoded without explanation. Consider extracting this to a named constant (e.g., MinimumHeroImageHeight) to improve code clarity and maintainability.