enh(stream): merge from main #33284

wangmm0220 · 2025-10-16T09:09:38Z

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

Is the user manual updated?
Are the test cases passed and automated?
Is there no significant decrease in test coverage?

…binary name

Refactor test_subscribeDb0.py to improve readability and maintainability.

feat: unique getBuildPath invoke and ignore .git branch name contain …

)

* fix: test case * fix: exception desc

* enh(stream): add max wait config for stream batch request * enh: add runner low latency handling --------- Co-authored-by: Jinqing Kuang <[email protected]>

、

* docs: add error code prefix define introduct * docs: modify english docs * docs: remove show error code command * docs: add TDengine TSDB Error Code chapter * docs: remove tips area * docs: rename title to TDengine TSDB Business Error * docs: rename error code struct * Update docs/en/14-reference/09-error-code.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update docs/zh/14-reference/09-error-code.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * docs: linux error codes url link to chrom --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…#33266) * chore(jdbc): update jdbc version * docs: add connection type descriptions in 05-connector * docs: add WebSocket error codes for C# connector * docs: add rust connector error codes * docs: modify conector and error code page --------- Co-authored-by: t_max <[email protected]> Co-authored-by: qevolg <[email protected]>

* enh: add wrapper hint * fix: build error * fix: build error for bit move * fix: update copyright to 2025 * fix: accept review advise for ci * fix: markdown blank remove * fix: restore 09-error-code.md from main branch

gemini-code-assist · 2025-10-16T09:12:51Z

Summary of Changes

Hello @wangmm0220, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a broad set of changes from the main development branch, primarily focusing on improving the clarity and maintainability of TDengine's documentation, enhancing the robustness of error handling mechanisms, and refining the core logic for stream processing. It also includes significant updates to the test suite to reflect these changes and ensure continued stability.

Highlights

Documentation Refactoring: Centralized and streamlined documentation for connector types, supported platforms, and error codes across multiple language-specific guides (C/C++, Java, Python, Go, Node.js, C#, Rust) by introducing reusable MDX components and a comprehensive error code reference.
Enhanced Error Handling and Diagnostics: Improved client driver loading error messages with new wrapper hint functionality, providing more user-friendly diagnostic information. Detailed error code documentation was expanded with structured prefixes and examples.
Stream Processing Enhancements: Introduced a new configuration parameter tsStreamBatchRequestWaitMs to control batch request waiting time for stream processing, and added lowLatencyCalc to stream runner deployment messages, allowing for more granular control over stream calculation latency.
Internal Code Refinements: Refactored stream execution task reset logic, improved memory management in various components (e.g., nodesCallocImpl, buildCmdMsg), and enhanced error logging in monitoring and database operations.
Test Infrastructure Updates: Updated numerous Python test cases to use a centralized utility function tdCom.getBuildPath() for locating build artifacts, re-enabled decimal type test cases, and added a new test for the LAST aggregate function with composite primary keys.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request appears to be a large merge from the main branch, incorporating a wide variety of changes. Key updates include a significant refactoring of the documentation to centralize information on connectors and error codes, which improves maintainability. The REST connector seems to be deprecated in favor of WebSocket, and this is reflected in the documentation. The C/C++ codebase has received several critical bug fixes, addressing memory leaks and improving correctness. A new feature for low-latency stream processing has been added. Additionally, error handling for the client wrapper has been improved with user-friendly hints.

While the changes are largely positive, I've identified a critical security vulnerability in one of the new Java examples due to SQL injection risk. I've also noted a place in the stream processing logic where error handling could be made more transparent with a comment. Please see the specific comments for details.

For future merges, providing a summary of the key changes in the pull request description would be very helpful for reviewers, even for merge commits.

gemini-code-assist · 2025-10-16T09:16:26Z

...mybatisplus-demo/src/main/java/com/taosdata/example/mybatisplusdemo/mapper/MetersMapper.java

    @Update("drop stable if exists meters")
    void dropTable();
+
+    @Select("select count(*) from meters where tbname = '${tbname}'")


Using string interpolation (${...}) in SQL queries is vulnerable to SQL injection. This is a critical security risk because it allows attackers to execute arbitrary SQL commands. You should use parameter binding (#{...}) instead, which lets MyBatis use prepared statements to safely substitute values.

Suggested change

@Select("select count(*) from meters where tbname = '${tbname}'")

@Select("select count(*) from meters where tbname = #{tbname}")

gemini-code-assist · 2025-10-16T09:16:26Z

source/dnode/vnode/src/vnd/vnodeStream.c

+  if (code == TSDB_CODE_PAR_TABLE_NOT_EXIST || code == TSDB_CODE_TDB_TABLE_NOT_EXIST){
+    code = TDB_CODE_SUCCESS;
+  }


This logic swallows TABLE_NOT_EXIST errors and treats them as success. While this might be intentional for stream processing to be robust against dropped source tables, it can hide bugs where a table is unexpectedly missing. To improve maintainability and prevent future confusion, please add a comment explaining why this error is being safely ignored.

SallyHuo-TAOS and others added 23 commits October 13, 2025 18:19

feat: unique getBuildPath invoke and ignore .git branch name contain …

62222bb

…binary name

feat: unique getBuildPath invoke and ignore .git branch name contain …

f505eab

…binary name

Update test_oldcase_taosdShell.py

4f4f946

Update test_subscribeStb3.py

f00e71c

Refactor test_subscribeDb0.py for clarity

8cdcb62

Refactor test_subscribeDb0.py to improve readability and maintainability.

Update test_compatibility_cross_version.py

cb0e21b

Merge pull request #33233 from taosdata/feat/huoh/TD-33281

98b6d11

feat: unique getBuildPath invoke and ignore .git branch name contain …

enh: TD-38278-print-error-code (#33231)

34b3e08

enh(last): enable using cache when select last and composite key (#33234

f168881

)

Fix/test case/err desc main (#33246)

1ac2412

* fix: test case * fix: exception desc

enh: add and apply trigger latency config (#33245)

0dc3023

* enh(stream): add max wait config for stream batch request * enh: add runner low latency handling --------- Co-authored-by: Jinqing Kuang <[email protected]>

fix(stream): fix memory leak in vtable data merge (#33194)

80d6713

、

enh(last): enable reading cache when select last and tags (#33236)

648a6d4

Merge branch '3.3.6' into merge/3.3.6tomain

6bc92e1

merge: from 3.3.6 to main #33255

e9d53dd

fix: TD-37490 ci case (#33187)

892e1ac

chore: wrapper library add hint message (#33257)

4c162c7

* enh: add wrapper hint * fix: build error * fix: build error for bit move * fix: update copyright to 2025 * fix: accept review advise for ci * fix: markdown blank remove * fix: restore 09-error-code.md from main branch

fix(stream): fix trigger waking for available runner (#33264)

7cc4895

docs: update c native stmt2 example (#33272)

ce01c99

fix[TD-38121]: fix two tdb bugs (#33260)

88bb90d

enh(stream): reset table scan in reader (#33247)

a190048

wangmm0220 requested review from a team, dapan1121, guanshengliang, hzcheng and zitsen as code owners October 16, 2025 09:09

wangmm0220 merged commit e53920d into fix/TD-37251-tablelist-main Oct 16, 2025
3 checks passed

taosdata-bot bot added the team engine label Oct 16, 2025

gemini-code-assist bot reviewed Oct 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

enh(stream): merge from main #33284

enh(stream): merge from main #33284

Uh oh!

wangmm0220 commented Oct 16, 2025

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 16, 2025

Uh oh!

gemini-code-assist bot Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

	@Select("select count(*) from meters where tbname = '${tbname}'")
	@Select("select count(*) from meters where tbname = #{tbname}")

enh(stream): merge from main #33284

enh(stream): merge from main #33284

Uh oh!

Conversation

wangmm0220 commented Oct 16, 2025

Description

Checklist

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 16, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants