Fix documentation in cell mod#35895

F001 · 2016-08-22T07:37:37Z

The implementation of Rc type in this doc is outdated.

rust-highfive · 2016-08-22T07:37:45Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2016-08-22T10:20:23Z

src/libcore/cell.rs

Why adding pub in here?

Agree. The pub keyword is removed.

steveklabnik · 2016-08-22T19:16:33Z

Seems like the build failure is spurious.

I share @GuillaumeGomez 's question about pub, but otherwise looks good to me

GuillaumeGomez · 2016-08-22T21:26:18Z

Travis failed. Run:

make tidy

to see what's wrong.

steveklabnik · 2016-08-23T15:36:53Z

Hm, still a strange failure. Let's see how it does on real CI, thanks!

@bors: r+ rollup

bors · 2016-08-23T15:36:55Z

📌 Commit 424698b has been approved by steveklabnik

eddyb · 2016-08-23T18:09:14Z

src/libcore/cell.rs

This is still over 100 columns wide, please split into multiple lines.

eddyb · 2016-08-23T18:09:24Z

@bors r-

GuillaumeGomez · 2016-08-23T20:44:05Z

And run make tidy.

GuillaumeGomez · 2016-08-24T09:22:17Z

And please squash your commits.

F001 · 2016-08-29T03:02:32Z

@steveklabnik Just Ping. Could you please help to merge this PR?

eddyb · 2016-08-29T04:17:30Z

@bors r=steveklabnik

bors · 2016-08-29T04:17:31Z

📌 Commit f4c55dd has been approved by steveklabnik

bors · 2016-08-29T08:38:46Z

⌛ Testing commit f4c55dd with merge 404d580...

bors · 2016-08-29T08:41:35Z

💔 Test failed - auto-mac-64-opt-rustbuild

arielb1 · 2016-08-29T16:58:26Z

@bors retry

Fix documentation in cell mod The implementation of Rc type in this doc is outdated.

Rollup of 16 pull requests - Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125 - Failed merges: #35771, #35810

Fix documentation in cell mod The implementation of Rc type in this doc is outdated.

Rollup of 16 pull requests - Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125 - Failed merges: #35771, #35810

rust-highfive assigned aturon Aug 22, 2016

GuillaumeGomez reviewed Aug 22, 2016
View reviewed changes

GuillaumeGomez assigned steveklabnik and unassigned aturon Aug 22, 2016

eddyb reviewed Aug 23, 2016
View reviewed changes

src/libcore/cell.rs Outdated

Copy link

Member

eddyb Aug 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still over 100 columns wide, please split into multiple lines.

Fix documentation in cell mod

f4c55dd

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016

Rollup merge of rust-lang#35895 - F001:patch-1, r=steveklabnik

ab5e229

Fix documentation in cell mod The implementation of Rc type in this doc is outdated.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016

Rollup merge of rust-lang#35895 - F001:patch-1, r=steveklabnik

290095d

Fix documentation in cell mod The implementation of Rc type in this doc is outdated.

GuillaumeGomez mentioned this pull request Aug 30, 2016

Rollup of 16 pull requests #36126

Merged

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016

Rollup merge of rust-lang#35895 - F001:patch-1, r=steveklabnik

325b711

Fix documentation in cell mod The implementation of Rc type in this doc is outdated.

bors merged commit f4c55dd into rust-lang:master Aug 30, 2016

F001 deleted the patch-1 branch August 31, 2016 01:04

Uh oh!

Conversation

F001 commented Aug 22, 2016

Uh oh!

rust-highfive commented Aug 22, 2016

Uh oh!

GuillaumeGomez Aug 22, 2016

Choose a reason for hiding this comment

Uh oh!

F001 Aug 23, 2016

Choose a reason for hiding this comment

Uh oh!

steveklabnik commented Aug 22, 2016

Uh oh!

GuillaumeGomez commented Aug 22, 2016

Uh oh!

steveklabnik commented Aug 23, 2016

Uh oh!

bors commented Aug 23, 2016

Uh oh!

eddyb Aug 23, 2016

Choose a reason for hiding this comment

Uh oh!

eddyb commented Aug 23, 2016

Uh oh!

GuillaumeGomez commented Aug 23, 2016

Uh oh!

GuillaumeGomez commented Aug 24, 2016

Uh oh!

F001 commented Aug 29, 2016

Uh oh!

eddyb commented Aug 29, 2016

Uh oh!

bors commented Aug 29, 2016

Uh oh!

bors commented Aug 29, 2016

Uh oh!

bors commented Aug 29, 2016

Uh oh!

arielb1 commented Aug 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants