improve `BitAnd` trait documentation#35993

matthew-piziak · 2016-08-25T19:33:03Z

This pull request is based on the discussion in PR #35927.

Add a module-level note that && and || are short-circuiting operators and not overloadable.

Add a simple Scalar example that lifts the & operator to a trivial struct tuple.

Make BooleanVector a struct tuple.

Derive PartialEq for BooleanVector instead of implementing it.

Adds a fn main wrapper so that the example can integrate with Rust Playground.

rust-highfive · 2016-08-25T19:33:08Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

matthew-piziak · 2016-08-25T19:35:51Z

r? @GuillaumeGomez

GuillaumeGomez · 2016-08-26T09:22:28Z

src/libcore/ops.rs

Could you some comments here (at least to explain a bit about lhs and rhs, I think some people don't know what this is).

How's this?

This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground. simplified bitand expression add a comment explaining what "rhs" means

GuillaumeGomez · 2016-08-26T17:03:12Z

@bors: r+ rollup

bors · 2016-08-26T17:03:13Z

📌 Commit e2d9974 has been approved by GuillaumeGomez

…=GuillaumeGomez improve `BitAnd` trait documentation This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground.

bors · 2016-08-29T08:47:45Z

⌛ Testing commit e2d9974 with merge 01a010a...

bors · 2016-08-29T08:50:45Z

💔 Test failed - auto-mac-64-opt-rustbuild

arielb1 · 2016-08-29T16:57:53Z

@bors retry

…=GuillaumeGomez improve `BitAnd` trait documentation This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground.

Rollup of 11 pull requests - Successful merges: #35418, #35759, #35862, #35863, #35962, #35977, #35993, #35997, #36054, #36056, #36070 - Failed merges: #35771, #35810

…=GuillaumeGomez improve `BitAnd` trait documentation This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground.

Rollup of 16 pull requests - Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125 - Failed merges: #35771, #35810

…=GuillaumeGomez improve `BitAnd` trait documentation This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground.

Rollup of 16 pull requests - Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125 - Failed merges: #35771, #35810

@GuillaumeGomez

These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary "xor" operator in Rust, so here it's expressed as (a || b) && !(a && b). r? @GuillaumeGomez improved documentation a la PR rust-lang#35993

@GuillaumeGomez

This is the augmented-assignment version of PR rust-lang#35809. r? @GuillaumeGomez improved documentation a la PR rust-lang#35993

rust-highfive assigned aturon Aug 25, 2016

rust-highfive assigned GuillaumeGomez and unassigned aturon Aug 25, 2016

GuillaumeGomez reviewed Aug 26, 2016
View reviewed changes

matthew-piziak force-pushed the bitwise-and-redux branch from 9769a7f to a9e9928 Compare August 26, 2016 15:14

matthew-piziak force-pushed the bitwise-and-redux branch from 8a5f483 to e2d9974 Compare August 26, 2016 17:02

steveklabnik mentioned this pull request Aug 26, 2016

Rollup of 16 pull requests #36021

Closed

GuillaumeGomez mentioned this pull request Aug 29, 2016

Rollup of 11 pull requests #36090

Closed

matthew-piziak mentioned this pull request Aug 29, 2016

replace BitAndAssign example with something more evocative #35927

Merged

matthew-piziak mentioned this pull request Aug 29, 2016

add evocative examples for BitOr and BitXor #35926

Merged

GuillaumeGomez mentioned this pull request Aug 30, 2016

Rollup of 16 pull requests #36126

Merged

bors merged commit e2d9974 into rust-lang:master Aug 30, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

improve `BitAnd` trait documentation#35993