Skip to content

Updated code sample in chapter on syntax extensions.#35962

Merged
bors merged 1 commit intorust-lang:masterfrom
regexident:compiler-plugin-docs
Aug 30, 2016
Merged

Updated code sample in chapter on syntax extensions.#35962
bors merged 1 commit intorust-lang:masterfrom
regexident:compiler-plugin-docs

Conversation

@regexident
Copy link
Contributor

@regexident regexident commented Aug 24, 2016

The affected API apparently had changed with commit d59accf.

Further more I had to add

[lib]
name = "roman_numerals"
crate-type = ["dylib"]

to Cargo.toml as I otherwise got this compiler error (despite #![crate_type="dylib"]):

[E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?

@regexident
Updated code sample in chapter on syntax extensions.
bf22a7a 
The affected API apparently had changed with commit d59accf.
@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 24, 2016

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

steveklabnik commented Aug 24, 2016

@bors: r+ rollup

thank you!

@bors
Copy link
Collaborator

bors commented Aug 24, 2016

📌 Commit bf22a7a has been approved by steveklabnik

@steveklabnik
Copy link
Contributor

steveklabnik commented Aug 24, 2016

(And yeah, a note would be cool as well)

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 25, 2016
@steveklabnik
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
f8e05a7 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
@steveklabnik steveklabnik mentioned this pull request Aug 25, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
@steveklabnik
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
23df512 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
@steveklabnik steveklabnik mentioned this pull request Aug 26, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
@steveklabnik
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
d0ad4c0 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
@steveklabnik steveklabnik mentioned this pull request Aug 26, 2016
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
@Manishearth
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
b65f5a1 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
@Manishearth Manishearth mentioned this pull request Aug 27, 2016
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 29, 2016
Closed
@bors
Copy link
Collaborator

bors commented Aug 29, 2016

⌛ Testing commit bf22a7a with merge 1c12c28...

@bors
Copy link
Collaborator

bors commented Aug 29, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@regexident
Copy link
Contributor Author

regexident commented Aug 29, 2016

This looks like a git error to me. Anything I can do to get this to pass?

@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2016

@bors retry

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
1522b9e 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
bors added a commit that referenced this pull request Aug 29, 2016
@bors
Auto merge of #36090 - GuillaumeGomez:rollup, r=GuillaumeGomez
aee9774 
Rollup of 11 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35962, #35977, #35993, #35997, #36054, #36056, #36070
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
52a42b1 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 30, 2016
Merged
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of #36126 - GuillaumeGomez:rollup, r=GuillaumeGomez
badf406 
Rollup of 16 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge of rust-lang#35962 - regexident:compiler-plugin-docs, r=…
8d808a2 
…steveklabnik

Updated code sample in chapter on syntax extensions.

The affected API apparently had changed with commit d59accf.

---

Further more I had to add

```toml
[lib]
name = "roman_numerals"
crate-type = ["dylib"]
```

to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`):

    [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format

Might be worth adding a note about that?
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of #36126 - GuillaumeGomez:rollup, r=GuillaumeGomez
4473130 
Rollup of 16 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
@bors bors merged commit bf22a7a into rust-lang:master Aug 30, 2016
@regexident regexident deleted the compiler-plugin-docs branch August 30, 2016 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@regexident @rust-highfive @steveklabnik @bors @arielb1