Print more tags in rustdoc

[GuillaumeGomez]

r? @steveklabnik

cc @frewsxcv

A little screenshot:

[frewsxcv]

Returning Option<String> seems appropriate instead of possibly returning an empty string

[frewsxcv]

["repr"].iter().any(|x| x == &s)

Same goes above

[frewsxcv]

+0 for me on this. I don't like displaying attributes in the docs in general like we do currently with #[must_use], but at least this makes it a little more consistent than before. Let's see what others think.

[GuillaumeGomez]

cc #37012

[GuillaumeGomez]

I could add a show_attributes button or something like that?

[steveklabnik]

@bors: delegate=kmcallister

[bors]

✌️ @kmcallister can now approve this pull request

[steveklabnik]

I feel similarly to @frewsxcv .

/cc @rust-lang/tools @rust-lang/docs

[kmcallister]

The screenshot shows unbalanced brackets:

#[repr(i32])]
pub struct F;

[nrc]

I'd prefer not to do this by default - attributes are mostly an implementation detail and this adds visual clutter.

+1 for a show_attributes option some how.

On the implementation side - why have this ad hoc pretty printing? Why not use the source text? Or the compiler's pretty printer?

[GuillaumeGomez]

@nrc: I actually didn't know there was. And if there was, why not using it from the start? If it's in order to filter the output, we'll still need it.

[GuillaumeGomez]

Ok, so now attributes are hidden by default:

And when they're displayed they look like this:

cc @rust-lang/docs

[steveklabnik]

Similarly to #37250, gonna wait until after the beta branch to merge this

[steveklabnik]

Beta has been branched! Let's see how the wider community feels about this.

@bors: r+

[bors]

📌 Commit 520d5f4 has been approved by steveklabnik