Point to type argument span when used as trait#37428

estebank · 2016-10-27T03:56:25Z

Given the following code:

struct Foo<T: Clone>(T);

use std::ops::Add;

impl<T: Clone, Add> Add for Foo<T> {
  type Output = usize;

  fn add(self, rhs: Self) -> Self::Output {
    unimplemented!();
  }
}

present the following output:

error[E0404]: `Add` is not a trait
 --> file3.rs:5:21
  |
5 | impl<T: Clone, Add> Add for Okok<T> {
  |                ---  ^^^ expected trait, found type parameter
  |                |
  |                type parameter defined here

Fixes #35987.

rust-highfive · 2016-10-27T03:56:39Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

estebank · 2016-10-27T03:57:24Z

src/libsyntax/ast.rs

I'm not convinced that this is the best way of getting the type argument's span. Does anyone have a pointer as to an alternative?

I remember doing such a thing but can't find the PR. From my point of view, this is correct. However I can totally overpass a better solution.

Anything in mind @eddyb?

Seems okay. If there are duplicate type parameter names, you'll get a different error for that.

estebank · 2016-11-07T04:31:46Z

r? @jonathandturner

sanxiyn · 2016-11-07T04:55:43Z

src/test/ui/span/issue-35987.rs

Rust uses 4 spaces indent.

sanxiyn · 2016-11-07T19:24:30Z

src/libsyntax/ast.rs

This is redundant. You can do &t.ident.name.as_str() == name instead.

sanxiyn · 2016-11-07T19:25:52Z

src/libsyntax/ast.rs

You can return Some(t.span); instead of breaking, and get rid of the local variable span.

Yeah, returning is probably slightly cleaner/easier to read.

sophiajt · 2016-11-08T13:18:00Z

A nit or two to fix, but otherwise seems okay to me.

Given the following code: ```rust struct Foo<T: Clone>(T); use std::ops::Add; impl<T: Clone, Add> Add for Foo<T> { type Output = usize; fn add(self, rhs: Self) -> Self::Output { unimplemented!(); } } ``` present the following output: ```nocode error[E0404]: `Add` is not a trait --> file3.rs:5:21 | 5 | impl<T: Clone, Add> Add for Okok<T> { | --- ^^^ expected trait, found type parameter | | | type parameter defined here ```

estebank · 2016-11-09T01:16:19Z

@jonathandturner fixed.

sanxiyn · 2016-11-09T06:29:03Z

@bors r+

bors · 2016-11-09T06:29:04Z

📌 Commit 3edb4fc has been approved by sanxiyn

…=sanxiyn Point to type argument span when used as trait Given the following code: ``` rust struct Foo<T: Clone>(T); use std::ops::Add; impl<T: Clone, Add> Add for Foo<T> { type Output = usize; fn add(self, rhs: Self) -> Self::Output { unimplemented!(); } } ``` present the following output: ``` nocode error[E0404]: `Add` is not a trait --> file3.rs:5:21 | 5 | impl<T: Clone, Add> Add for Okok<T> { | --- ^^^ expected trait, found type parameter | | | type parameter defined here ``` Fixes rust-lang#35987.

Rollup of 15 pull requests - Successful merges: #36868, #37134, #37229, #37250, #37370, #37428, #37432, #37472, #37524, #37614, #37622, #37627, #37636, #37644, #37654 - Failed merges: #37463, #37542, #37645

rust-highfive assigned pnkfelix Oct 27, 2016

estebank commented Oct 27, 2016

View reviewed changes

estebank force-pushed the generic-type-error-span branch 5 times, most recently from 870fe6a to 169d580 Compare October 27, 2016 21:25

rust-highfive assigned sophiajt and unassigned pnkfelix Nov 7, 2016

sanxiyn reviewed Nov 7, 2016

View reviewed changes

estebank force-pushed the generic-type-error-span branch from 169d580 to c56cc5f Compare November 7, 2016 05:16

sanxiyn reviewed Nov 7, 2016

View reviewed changes

estebank force-pushed the generic-type-error-span branch from c56cc5f to 0037756 Compare November 8, 2016 19:56

estebank force-pushed the generic-type-error-span branch from 0037756 to 3edb4fc Compare November 8, 2016 22:17

eddyb mentioned this pull request Nov 9, 2016

Rollup of 15 pull requests #37670

Merged

bors merged commit 3edb4fc into rust-lang:master Nov 9, 2016

estebank deleted the generic-type-error-span branch November 9, 2023 05:28

Uh oh!

Conversation

estebank commented Oct 27, 2016

Uh oh!

rust-highfive commented Oct 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estebank commented Nov 7, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sophiajt commented Nov 8, 2016

Uh oh!

estebank commented Nov 9, 2016

Uh oh!

sanxiyn commented Nov 9, 2016

Uh oh!

bors commented Nov 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants