Clarify that send_to might fail in certain cases#37432
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 9, 2016
Merged
Conversation
Member
|
Hm this doesn't panic, right? It'd return an error? |
Contributor
|
This doesn't panic, it returns an error. In the linked issue |
Contributor
Author
|
My bad, updated now. |
src/libstd/net/udp.rs
Outdated
Member
There was a problem hiding this comment.
I think that we may want to generalize this error to more than just this issue. It may be worth just mentioning that the returned addresses from ToSocketAddrs must match the IPv4 or IPv6-ness of the address the UDP socket is bound to. This problem isn't only related to localhost I believe.
Contributor
|
Waiting for updates to @alexcrichton's feedback. |
Contributor
Author
|
Sorry, this fell off my radar. Updated now. |
Member
|
@bors: r+ Thanks! |
Collaborator
|
📌 Commit 50bfc23 has been approved by |
sfackler
changed the title
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 9, 2016
Clarify that send_to might panic in certain cases Closes rust-lang#34202 r? @alexcrichton
bors
added a commit
that referenced
this pull request
Nov 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34202
r? @alexcrichton