Don't track local_needs_drop separately in qualify_consts.#47306

alexreg · 2018-01-10T03:20:03Z

No description provided.

eddyb · 2018-01-10T03:35:58Z

src/librustc_mir/transform/qualify_consts.rs

Hmm, I feel like this shouldn't happen unless we have a Move. Also, we can probably "just" remove NEEDS_DROP here from self.temp_qualif[local], and check that later, instead of having a separate bitvec.

eddyb · 2018-01-11T17:30:15Z

src/librustc_mir/transform/qualify_consts.rs

Need to keep this comment around because this is still emulated until we use something more like what drop elaboration does.

eddyb · 2018-01-11T19:08:25Z

src/test/compile-fail/static-drop-scope.rs

You need to add //~^ ERROR comments (assuming they get caught now).

alexreg · 2018-01-11T20:08:17Z

Tests passing. LGTM, @eddyb!

…-lang#47351).

eddyb · 2018-01-11T20:16:21Z

@bors r+

bors · 2018-01-11T20:16:22Z

📌 Commit e2c1a93 has been approved by eddyb

Don't track local_needs_drop separately in qualify_consts. None

Rollup of 24 pull requests - Successful merges: #46985, #47069, #47081, #47185, #47282, #47283, #47288, #47289, #47298, #47305, #47306, #47307, #47310, #47324, #47328, #47331, #47340, #47343, #47344, #47352, #47357, #47365, #47375, #47382 - Failed merges: #47334

eddyb reviewed Jan 10, 2018

View reviewed changes

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2018

eddyb reviewed Jan 11, 2018

View reviewed changes

src/test/compile-fail/static-drop-scope.rs Outdated

Copy link

Member

eddyb Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add //~^ ERROR comments (assuming they get caught now).

Don't track local_needs_drop separately in qualify_consts (fixes rust…

e2c1a93

…-lang#47351).

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Jan 12, 2018

Rollup merge of rust-lang#47306 - alexreg:dataflow-analysis, r=eddyb

df8f2c6

Don't track local_needs_drop separately in qualify_consts. None

kennytm mentioned this pull request Jan 12, 2018

Rollup of 24 pull requests #47392

Merged

bors merged commit e2c1a93 into rust-lang:master Jan 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Don't track local_needs_drop separately in qualify_consts.#47306