Use the new fs_read_write functions in rustc internals#47328

mbrubeck · 2018-01-10T17:13:26Z

Uses fs::read and fs::write (added by #45837) where appropriate, to simplify code and dog-food these new APIs. This also improves performance, when combined with #47324.

rust-highfive · 2018-01-10T17:13:36Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

sfackler · 2018-01-10T22:19:09Z

src/librustdoc/html/render.rs

This should be read_string, right?

The original used read_to_string but there's no reason to create a string here; it's just copying the contents to a new file. Actually, this should use fs::copy...

sfackler · 2018-01-10T22:19:21Z

src/librustdoc/html/render.rs

This can be read_string.

mbrubeck · 2018-01-10T22:59:22Z

Addressed review comments.

sfackler · 2018-01-10T23:00:52Z

@bors r+

bors · 2018-01-10T23:00:53Z

📌 Commit 3f9c057 has been approved by sfackler

Use the new fs_read_write functions in rustc internals Uses `fs::read` and `fs::write` (added by rust-lang#45837) where appropriate, to simplify code and dog-food these new APIs. This also improves performance, when combined with rust-lang#47324.

Rollup of 12 pull requests - Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344 - Failed merges:

Use the new fs_read_write functions in rustc internals Uses `fs::read` and `fs::write` (added by rust-lang#45837) where appropriate, to simplify code and dog-food these new APIs. This also improves performance, when combined with rust-lang#47324.

Rollup of 24 pull requests - Successful merges: #46985, #47069, #47081, #47185, #47282, #47283, #47288, #47289, #47298, #47305, #47306, #47307, #47310, #47324, #47328, #47331, #47340, #47343, #47344, #47352, #47357, #47365, #47375, #47382 - Failed merges: #47334

rust-highfive assigned pnkfelix Jan 10, 2018

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2018

sfackler reviewed Jan 10, 2018

View reviewed changes

src/librustdoc/html/render.rs Outdated

Copy link

Member

sfackler Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be read_string.

Use the new fs_read_write functions in rustc internals

3f9c057

mbrubeck force-pushed the fs_read branch from f931bf9 to 3f9c057 Compare January 10, 2018 22:58

kennytm mentioned this pull request Jan 11, 2018

Rollup of 12 pull requests #47350

Closed

bors added a commit that referenced this pull request Jan 11, 2018

Auto merge of #47350 - kennytm:rollup, r=kennytm

27270e6

Rollup of 12 pull requests - Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344 - Failed merges:

bors added a commit that referenced this pull request Jan 12, 2018

Auto merge of #47350 - kennytm:rollup, r=kennytm

712e755

Rollup of 12 pull requests - Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344 - Failed merges:

kennytm mentioned this pull request Jan 12, 2018

Rollup of 24 pull requests #47392

Merged

bors merged commit 3f9c057 into rust-lang:master Jan 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use the new fs_read_write functions in rustc internals#47328