Fix panic strings.#47307

dlrobertson · 2018-01-10T03:22:02Z

Fix panic string in check_ast_crate.
Update panic string for Duration subtraction on overflow/underflow.

Not sure if the changes to Duration are helpful/needed. Mostly just a nit.
Otherwise this is just a one character change :)

On another note: I hit the panic in check_ast_crate when compiling
m-labs/smoltcp with the following:

cargo test --doc --no-default-features --features "std socket-raw"`

rust-highfive · 2018-01-10T03:22:09Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

kennytm · 2018-01-10T12:37:07Z

src/libstd/time/duration.rs

Please revert these changes. The term "overflow" is correct, see #46898.

- Fix panic string in `check_ast_crate`.

dlrobertson · 2018-01-10T21:40:52Z

Updated! Such a massive PR lol

kennytm · 2018-01-10T21:45:03Z

Thanks!

@bors r+ rollup

bors · 2018-01-10T21:45:05Z

📌 Commit c78679d has been approved by kennytm

shepmaster · 2018-01-10T22:29:04Z

Such a massive PR lol

On the flip side, a lot of times the smallest changes are the ones you have to scrutinize the hardest. It's nice to have easier ones every so often ;-)

…nnytm Fix panic strings. - Fix panic string in `check_ast_crate`. - Update panic string for Duration subtraction on overflow/underflow. Not sure if the changes to `Duration` are helpful/needed. Mostly just a nit. Otherwise this is just a one character change :) On another note: I hit the panic in `check_ast_crate` when compiling [m-labs/smoltcp] with the following: ``` cargo test --doc --no-default-features --features "std socket-raw"` ``` [m-labs/smoltcp]: https://github.com/m-labs/smoltcp

Rollup of 12 pull requests - Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344 - Failed merges:

…nnytm Fix panic strings. - Fix panic string in `check_ast_crate`. - Update panic string for Duration subtraction on overflow/underflow. Not sure if the changes to `Duration` are helpful/needed. Mostly just a nit. Otherwise this is just a one character change :) On another note: I hit the panic in `check_ast_crate` when compiling [m-labs/smoltcp] with the following: ``` cargo test --doc --no-default-features --features "std socket-raw"` ``` [m-labs/smoltcp]: https://github.com/m-labs/smoltcp

Rollup of 24 pull requests - Successful merges: #46985, #47069, #47081, #47185, #47282, #47283, #47288, #47289, #47298, #47305, #47306, #47307, #47310, #47324, #47328, #47331, #47340, #47343, #47344, #47352, #47357, #47365, #47375, #47382 - Failed merges: #47334

rust-highfive assigned shepmaster Jan 10, 2018

kennytm reviewed Jan 10, 2018

View reviewed changes

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2018

Fix panic strings.

c78679d

- Fix panic string in `check_ast_crate`.

dlrobertson force-pushed the fix_panic_strings branch from ce22894 to c78679d Compare January 10, 2018 21:39

kennytm mentioned this pull request Jan 10, 2018

Rollup of 11 pull requests #47339

Closed

kennytm mentioned this pull request Jan 11, 2018

Rollup of 12 pull requests #47350

Closed

bors added a commit that referenced this pull request Jan 11, 2018

Auto merge of #47350 - kennytm:rollup, r=kennytm

27270e6

Rollup of 12 pull requests - Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344 - Failed merges:

bors added a commit that referenced this pull request Jan 12, 2018

Auto merge of #47350 - kennytm:rollup, r=kennytm

712e755

Rollup of 12 pull requests - Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344 - Failed merges:

kennytm mentioned this pull request Jan 12, 2018

Rollup of 24 pull requests #47392

Merged

bors merged commit c78679d into rust-lang:master Jan 12, 2018

dlrobertson deleted the fix_panic_strings branch January 14, 2018 20:05

oberien mentioned this pull request Jan 15, 2018

Add UnboundedIterator Trait #47082

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix panic strings.#47307