Enable stack-overflow detection on musl for non-main threads#75703
Enable stack-overflow detection on musl for non-main threads#75703bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
|
I assume you have tested it, right? |
|
So, this fixes #31506? |
|
@malbarbo if you consider the issue #31506 to be about presence of the guard @mati865 I tested it with musl 1.2.0. CI uses 1.1.24 so we will have another |
|
@tmiasko I tested it locally and don't have the logs anymore. |
What did we get before, zero? garbage? If it was zero, then I guess the failure mode here is harmless, just computing an empty guard range, no better/worse than the |
tmiasko
force-pushed
the
stack-overflow-musl
branch
from
24f6207 to
6a80b13
Compare
|
It returned zero, but we panic if guard is missing. I adjusted code to use the page size as a fall-back in that specific case. |
|
OK, sounds good. @bors r+ |
|
📌 Commit 6a80b13 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 6a80b13 has been approved by |
|
@bors rollup |
Rollup of 8 pull requests Successful merges: - rust-lang#75672 (Move to intra-doc links for task.rs and vec.rs) - rust-lang#75702 (Clean up E0759 explanation) - rust-lang#75703 (Enable stack-overflow detection on musl for non-main threads) - rust-lang#75710 (Fix bad printing of const-eval queries) - rust-lang#75716 (Upgrade Emscripten on CI to 1.39.20 ) - rust-lang#75731 (Suppress ty::Float in MIR comments of ty::Const) - rust-lang#75733 (Remove duplicated alloc vec bench push_all_move) - rust-lang#75743 (Rename rustc_lexer::TokenKind::Not to Bang) Failed merges: r? @ghost
6 participants
No description provided.