fix(ui): redesign keyboard shortcuts dialog - #1735
Closed
sunheyi6 wants to merge 1 commit into
Closed
Conversation
sunheyi6
marked this pull request as ready for review
August 1, 2026 00:19
Contributor
Author
sunheyi6
added a commit
to sunheyi6/maka-agent
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1689.
Refs #1715.
padding={0}, while keepingLayoutContent padding={0}so the product body layout remains explicitly controlled.Kbd, so Windows rendersCtrl, macOS renders⌘, and alternative keys are no longer presented as key combinations.Root cause
The modal migration preserved the legacy help-sheet content while moving its shell to Astryx. The help dialog still passed
padding={0}, which zeroed the layout padding variables consumed byDialogHeaderand left the icon, title, and close action visually flush against the edge. The old shortcut data also encoded rendered glyphs instead of shortcut semantics, so Windows displayed macOS symbols and alternative keys looked like combinations.Screenshot
Verification
npx biome check apps/desktop/src/renderer/keyboard-help.tsx apps/desktop/src/renderer/locales/shell-copy.ts apps/desktop/src/renderer/styles/help.css apps/desktop/e2e/floating-layers.spec.tsnpm --workspace @maka/desktop run typechecknpm --workspace @maka/desktop run build:renderernpx playwright test --config e2e/playwright.config.ts e2e/floating-layers.spec.ts --grep "keyboard help keeps"— 1 passed in real Electrongit diff --check中文说明
概要
关闭 #1689。
参考 #1715。
padding={0}以恢复 Astryx 默认的弹窗标题栏内边距,同时保留LayoutContent padding={0},让产品内容区布局继续由自身明确控制。Kbd,使 Windows 显示Ctrl、macOS 显示⌘,并避免把候选按键错误呈现为组合键。根因
弹窗迁移在将外壳切换到 Astryx 时保留了旧版帮助速查表内容。帮助弹窗仍然传入
padding={0},这会把DialogHeader使用的布局内边距变量清零,导致图标、标题和关闭操作在视觉上紧贴边缘。旧快捷键数据还直接编码了渲染字符而不是快捷键语义,因此 Windows 会显示 macOS 符号,并且候选按键看起来像组合键。截图
验证
npx biome check apps/desktop/src/renderer/keyboard-help.tsx apps/desktop/src/renderer/locales/shell-copy.ts apps/desktop/src/renderer/styles/help.css apps/desktop/e2e/floating-layers.spec.tsnpm --workspace @maka/desktop run typechecknpm --workspace @maka/desktop run build:renderernpx playwright test --config e2e/playwright.config.ts e2e/floating-layers.spec.ts --grep "keyboard help keeps"— 在真实 Electron 中 1 项通过git diff --check