-
Notifications
You must be signed in to change notification settings - Fork 50.6k
[flags] Cleanup enableHalt
#35708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flags] Cleanup enableHalt
#35708
Conversation
|
Comparing: b932350...1c02f8c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
| // This could be a bug. Discovered while making enableAsyncDebugInfo dynamic for www. | ||
| // @gate enableHalt || (enableAsyncDebugInfo && __DEV__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got fixed in #34633
I suspect it only failed outside of experimental because of the inconsistent entrypoints due to mocking. Once we mocked to a consistent entrypoint, it got fixed.
[diff facebook/react@95ffd6cd...2dd9b7cf](facebook/react@95ffd6c...2dd9b7c) <details> <summary>React upstream changes</summary> - facebook/react#35724 - facebook/react#35711 - facebook/react#35710 - facebook/react#35708 - facebook/react#35705 - facebook/react#35700 </details>
This has shipped in 19.2