[Flight] Fix debug channel flag in Node.js server renderToPipeableStream #35724
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `createRequest` call in `renderToPipeableStream` was passing `debugChannel !== undefined` instead of `debugChannelReadable !== undefined` in the turbopack, esm, and parcel server implementations. The webpack version already had the correct check. This could cause the server to emit debug info even when only a write-only debug channel is provided with no readable side, potentially causing the client to block forever waiting for debug data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Comparing: 65db100...9c5d311 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
unstubbable
approved these changes
Feb 8, 2026
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 8, 2026
[diff facebook/react@95ffd6cd...2dd9b7cf](facebook/react@95ffd6c...2dd9b7c) <details> <summary>React upstream changes</summary> - facebook/react#35724 - facebook/react#35711 - facebook/react#35710 - facebook/react#35708 - facebook/react#35705 - facebook/react#35700 </details>
github-actions bot
pushed a commit
to anatolyshipov/react
that referenced
this pull request
Feb 9, 2026
…eam (facebook#35724) ## Summary - Fixes the `createRequest` call in `renderToPipeableStream` to pass `debugChannelReadable !== undefined` instead of `debugChannel !== undefined` in the turbopack, esm, and parcel Node.js server implementations - The webpack version already had the correct check; this brings the other bundler implementations in line The bug was introduced in facebook#33754. With `debugChannel !== undefined`, the server could signal that debug info should be emitted even when only a write-only debug channel is provided (no readable side), potentially causing the client to block forever waiting for debug data that never arrives. DiffTrain build for [2dd9b7c](facebook@2dd9b7c)
github-actions bot
pushed a commit
to anatolyshipov/react
that referenced
this pull request
Feb 9, 2026
…eam (facebook#35724) ## Summary - Fixes the `createRequest` call in `renderToPipeableStream` to pass `debugChannelReadable !== undefined` instead of `debugChannel !== undefined` in the turbopack, esm, and parcel Node.js server implementations - The webpack version already had the correct check; this brings the other bundler implementations in line The bug was introduced in facebook#33754. With `debugChannel !== undefined`, the server could signal that debug info should be emitted even when only a write-only debug channel is provided (no readable side), potentially causing the client to block forever waiting for debug data that never arrives. DiffTrain build for [2dd9b7c](facebook@2dd9b7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createRequestcall inrenderToPipeableStreamto passdebugChannelReadable !== undefinedinstead ofdebugChannel !== undefinedin the turbopack, esm, and parcel Node.js server implementationsThe bug was introduced in #33754. With
debugChannel !== undefined, the server could signal that debug info should be emitted even when only a write-only debug channel is provided (no readable side), potentially causing the client to block forever waiting for debug data that never arrives.Test plan
packages/react-server-dom-webpack/src/server/ReactFlightDOMServerNode.js:196🤖 Generated with Claude Code