[DevTools] Fix broken commit tree builder for initial operations #35710
+28
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/02-06-_devtools_stop_sending_current_root_id_in_operations
branch
from
9c47351 to
aa88640
Compare
eps1lon
force-pushed
the
sebbie/02-06-_devtools_stop_sending_current_root_id_in_operations
branch
from
aa88640 to
86ed9f4
Compare
eps1lon
changed the title
eps1lon
commented
Feb 6, 2026
Comment on lines
+5756
to
-5753
| flushPendingEvents(currentRoot); | ||
|
|
||
| currentRoot = (null: any); | ||
| }); | ||
|
|
||
| flushPendingEvents(); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This is the fix. We were flushing events for initial operations at the end without a root even though we may have been profiling.
hoxyq
approved these changes
Feb 6, 2026
Collaborator
Author
|
Might be hard to set this up. We need to have a committed root, then inject the hook (flushInitialOperation runs), start profiling, make an update and then let the commit tree builder run. But our tests have the hook injected before we commit. |
Collaborator
Author
|
Going to merge without a test for now to unblock work on moving the reconciliation to the passive phase. |
eps1lon
deleted the
sebbie/02-06-_devtools_stop_sending_current_root_id_in_operations
branch
This was referenced Feb 6, 2026
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 8, 2026
[diff facebook/react@95ffd6cd...2dd9b7cf](facebook/react@95ffd6c...2dd9b7c) <details> <summary>React upstream changes</summary> - facebook/react#35724 - facebook/react#35711 - facebook/react#35710 - facebook/react#35708 - facebook/react#35705 - facebook/react#35700 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally thought we can stop sending the root ID entirely but it's used by the commit tree builder. That made me realize #35093 introduced a regression.
Flushing pending events is only safe without a root if we're not profiling or if we're flushing events that don't mutate the tree (e.g. console errors and warnings)
Also removes handling of
TREE_OPERATION_REMOVE_ROOTin various frontends since that operation is no longer sent by the backend.How did you test this change?