[PAY-3286] Upload/edit confirmation drawer & modal rework #9326

raymondjacobson · 2024-07-31T01:55:25Z

Description

Consolidates web & mobile confirmation modals/drawers into these states:

PublishConfirmation
EarlyReleaseConfirmation
EditAccessConfirmation
HideConfirmation

which all use createModal now.

There are still some stylistic inconsistencies across the app, and some other inconsistencies between albums/tracks, but this gets us into a much better / maintainable state, deleting a lot of the redundant modals/drawers/redux slices

S/o @rickyrombo and @amendelsohn for pairing on the bulk of this.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Web

Tracks

Discard upload
Confirm upload
Confirm hidden upload
Confirm publish (from rocket icon on tile, edit page, and track page)
Confirm early release (from rocket icon on tile, edit page, and track page)
Confirm audience change
Confirm hidden

Albums

Discard upload
Confirm upload
Confirm hidden upload
Confirm publish (edit page, and album page)
Confirm early release (edit page, and album page)
Confirm audience change
Confirm hidden

Mobile

Tracks

Discard changes
Confirm publish (from rocket icon on tile, edit page, and track page)
Confirm early release (from rocket icon on tile, edit page, and track page)
Confirm audience change
Confirm hidden

Albums

Confirm publish (from album page & edit page)
Confirm early release (from album page & edit page)
Confirm audience change
Confirm hidden

changeset-bot · 2024-07-31T01:55:28Z

⚠️ No Changeset found

Latest commit: 1dc3e52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-07-31T01:58:08Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2024-08-03T18:57:53Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2024-08-03T19:08:09Z

Preview this change https://demo.audius.co/rj-modal-rework

gitguardian · 2024-08-03T19:08:33Z

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11648676	Triggered	Generic High Entropy Secret	`784df70`	core/infra/dev_config/discovery-one.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`784df70`	core/infra/dev_config/content-three.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`784df70`	core/infra/dev_config/content-two.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`784df70`	core/infra/dev_config/content-one.docker.env	View secret
13161486	Triggered	Generic High Entropy Secret	`1dc3e52`	core/infra/dev_config/content-three.docker.env	View secret
13161487	Triggered	Generic High Entropy Secret	`1dc3e52`	core/infra/dev_config/content-two.docker.env	View secret
13161489	Triggered	Generic High Entropy Secret	`1dc3e52`	core/infra/dev_config/content-one.docker.env	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-03T19:11:29Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers @sliptype

audius-infra · 2024-08-03T19:21:05Z

Preview this change https://demo.audius.co/rj-modal-rework

rickyrombo

The style differences 😭

heroic pr though! love to see it

packages/mobile/src/screens/edit-collection-screen/EditCollectionNavigator.tsx

packages/mobile/src/screens/edit-track-screen/EditTrackForm.tsx

amendelsohn

Approved pending fixes to the unwrapped dispatch confirm callbacks

Great effort here! Very happy with the result.

packages/common/src/store/ui/modals/hide-confirmation-modal/index.ts

packages/mobile/ios/Podfile.lock

amendelsohn · 2024-08-06T23:16:12Z

packages/mobile/src/app/Drawers.tsx

+  PublishConfirmation: PublishConfirmationDrawer,
+  EarlyReleaseConfirmation: EarlyReleaseConfirmationDrawer,


Why aren't all the new ones here? Are the others all rendered inside the forms?

Yep! in the navigators

amendelsohn · 2024-08-06T23:17:18Z

packages/mobile/src/components/edit/PriceAndAudienceField/PriceAndAudienceScreen.tsx

-        })
-      )
+      onOpenEditAccessConfirmationModal({
+        confirmCallback: navigation.goBack,


shouldn't this take action on confirm?

it doesn't need to because of how these forms are written currently (unfortunately). any action you take here mutates the form state, so this is kind of just informative.

amendelsohn · 2024-08-06T23:18:52Z

packages/mobile/src/components/overflow-menu-drawer/CollectionOverflowMenuDrawer.tsx

-      onOpen({ contentId: Number(id), contentType: 'playlist' })
+      openPublishConfirmation({
+        contentType: is_album ? 'album' : 'playlist',
+        confirmCallback: dispatch(publishPlaylist(Number(id)))


don't we need to wrap this in a function? otherwise it'll dispatch publishPlaylist as this open call is executed?

ohhhh good catch.

amendelsohn · 2024-08-06T23:19:27Z

packages/mobile/src/components/overflow-menu-drawer/TrackOverflowMenuDrawer.tsx

-      )
+      openPublishConfirmation({
+        contentType: 'playlist',
+        confirmCallback: dispatch(trackPageActions.makeTrackPublic(id))


confirm callback should be wrapped in a function

great catch on these

amendelsohn · 2024-08-06T23:24:32Z

packages/mobile/src/screens/edit-track-screen/components/HideConfirmationDrawer.tsx

+const messages = {
+  header: 'Confirm Update',
+  description:
+    "You're about to change your content from public to hidden. It will be hidden from the public and your followers will lose access.",


not your copy, but public to hidden. it will be hidden from the public feels like it uses the words hidden and public too many times in a row. It's like using the word to define the word 😂

while I agree... idk if it's worth changing

audius-infra · 2024-08-08T00:08:12Z

Preview this change https://demo.audius.co/rj-modal-rework

[7121301] Set is_custom_musical_key (#9418) Sebastian Klingler [ee99fd4] add is_custom_musical_key (#9416) Michelle Brier [f30a637] [PAY-3332] Remixers users endpoint (#9401) Reed [f2eabb1] [QA-1491] Fix balance polling bug (#9402) Raymond Jacobson [c5e7348] Fix lint (#9412) Raymond Jacobson [5598656] [QA-1356] Improve notification UI (#9390) Raymond Jacobson [dcb74eb] Fix useClickOutside (#9409) Andrew Mendelsohn [975b630] Add better error messages for Claimable Tokens Program (#9369) Marcus Pasell [17904fb] [PAY-3335] Add priority fees to SDK Solana usages (#9399) Marcus Pasell [c34cd83] Record Track Downloads via Entity Manager (#9103) Marcus Pasell [e59dfc8] [QA-1357] Remove excessive polling and amplitude events in unlock (#9391) Raymond Jacobson [26b2fc9] [QA-1496] fix unsafe read of audio analysis field (#9406) Randy Schott [abc1b37] [C-4934] Search bar fixes (#9403) Sebastian Klingler [d525a1b] [C-4930, C-4931] Add IconText, ArtistPick, and Identifier components to harmony and harmony native (#9400) Kyle Shanks [53bf3e2] [PAY-3321][PAY-3333] Add network cut feature flag and update staking bridge and payment router addresses (#9393) Saliou Diallo [4d0fbc2] [PAY-3294] Hide save/repost for locked albums on mobile (#9333) Reed [7e3a75c] [C-4936] FilterButton fixes (#9397) Sebastian Klingler [517251d] [PAY-3286] Upload/edit confirmation drawer & modal rework (#9326) Raymond Jacobson [dce9903] [C-4920] Only show bpm decimals if necessary (#9398) Sebastian Klingler [d6dbab0] [C-4937] Adding some pagination buttons (#9394) JD Francis [f183f7e] [PAY-3336] fix isPlaying logic for details screens (#9395) Randy Schott [5ed523f] Add comment actions: edit, delete, react (#9372) Isaac Solo [88e24b5] [C 4922] Update mobile filter button (#9385) Dylan Jeffers [901d811] [C-4923] Persist verified filter & general cleanup (#9384) Sebastian Klingler [bab49d6] Add Pin icon and Timestamp component to harmony and harmony-native (#9383) Kyle Shanks [53a1a32] [QA-1485] Redir to signup/in on direct /feed link (#9373) Raymond Jacobson [c618eb9] Improve useClickOutside (#9377) Sebastian Klingler [a97deb8] [PAY-2267] Update stage payment router and program addresses (#9387) Raymond Jacobson [def034f] [QA-1446] Fix popup alignment (#9389) Raymond Jacobson [c86bc70] Add priority fees to purchases (#9392) Marcus Pasell [66f1a0e] [PAY-3314] Track select dropdown for purchase/remix targeting (#9386) Andrew Mendelsohn [5fe7681] Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319) JD Francis [1ccfcd4] [PAY-3331] Purchase/sale endpoint filtering by content id (#9376) Reed [fc59a10] [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375) Raymond Jacobson [7712005] Fix short trending bug (#9378) Raymond Jacobson [196fdba] [QA-1114] Include menu items even if buttons are present (#9381) Raymond Jacobson [8e6b1e8] [QA-1486] Fix sign up select artists screen (#9371) Sebastian Klingler [34d4417] [PAY-3313] Targeted DMs CTA and modal (#9364) Andrew Mendelsohn [3a19003] [C-4921] Fix search v2 navigating back from profile (#9370) Sebastian Klingler [d266394] [C-4918] Improve harmony web FilterButton (#9366) Dylan Jeffers [4ef81a7] Bump mobile versions to 110 (#9367) Dylan Jeffers

Modal rework

b78628d

pull-request-size bot added the size/XXL label Jul 31, 2024

raymondjacobson changed the title ~~WIP: Modal rework~~ [PAY-3286] Upload/edit confirmation drawer & modal rework Aug 3, 2024

Implement mobile and clean up

b1f5d5c

Merge origin/main into rj-modal-rework

784df70

raymondjacobson requested review from amendelsohn, dylanjeffers and rickyrombo August 3, 2024 19:08

rickyrombo approved these changes Aug 5, 2024

View reviewed changes

packages/mobile/src/screens/edit-collection-screen/EditCollectionNavigator.tsx Outdated Show resolved Hide resolved

packages/mobile/src/screens/edit-track-screen/EditTrackForm.tsx Show resolved Hide resolved

amendelsohn approved these changes Aug 6, 2024

View reviewed changes

raymondjacobson added 2 commits August 7, 2024 16:52

Clean up

3d32566

Merge origin/main

1dc3e52

raymondjacobson merged commit 517251d into main Aug 8, 2024

raymondjacobson deleted the rj-modal-rework branch August 8, 2024 00:27

		PublishConfirmation: PublishConfirmationDrawer,
		EarlyReleaseConfirmation: EarlyReleaseConfirmationDrawer,

[PAY-3286] Upload/edit confirmation drawer & modal rework #9326

[PAY-3286] Upload/edit confirmation drawer & modal rework #9326

Uh oh!

Conversation

raymondjacobson commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Web

Tracks

Albums

Mobile

Tracks

Albums

Uh oh!

changeset-bot bot commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Jul 31, 2024

Uh oh!

audius-infra commented Aug 3, 2024

Uh oh!

audius-infra commented Aug 3, 2024

Uh oh!

gitguardian bot commented Aug 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Aug 3, 2024

Uh oh!

audius-infra commented Aug 3, 2024

Uh oh!

rickyrombo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amendelsohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

raymondjacobson commented Jul 31, 2024 •

edited

Loading

changeset-bot bot commented Jul 31, 2024 •

edited

Loading

gitguardian bot commented Aug 3, 2024 •

edited

Loading