Add comment actions: edit, delete, react #9372

isaacsolo · 2024-08-05T20:57:16Z

Description

Add comment reactions table and add edit, delete, react actions.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested e2e locally.

…jd/comments-e2e-scaffolding # Conflicts: # packages/common/src/services/remote-config/feature-flags.ts # packages/discovery-provider/src/tasks/entity_manager/entity_manager.py # packages/libs/src/sdk/api/generated/default/.openapi-generator/FILES # packages/libs/src/sdk/api/generated/default/models/index.ts

changeset-bot · 2024-08-05T20:57:21Z

⚠️ No Changeset found

Latest commit: 4d00619

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-08-05T20:57:52Z

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
2416685	Triggered	Generic High Entropy Secret	`f9f503a`	packages/libs/src/sdk/config/staging.ts	View secret
7150224	Triggered	Generic High Entropy Secret	`f9f503a`	packages/libs/src/sdk/scripts/generateServicesConfig.ts	View secret
7150224	Triggered	Generic High Entropy Secret	`f9f503a`	packages/libs/src/sdk/config/staging.ts	View secret
10622416	Triggered	Generic High Entropy Secret	`f9f503a`	packages/libs/src/sdk/scripts/generateServicesConfig.ts	View secret
10622416	Triggered	Generic High Entropy Secret	`f9f503a`	packages/libs/src/sdk/config/staging.ts	View secret
11648676	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/discovery-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/discovery-one.docker.env	View secret
11648676	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/discovery-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/discovery-one.docker.env	View secret
11648676	Triggered	Generic High Entropy Secret	`32419d7`	core/infra/dev_config/discovery-one.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/content-three.env	View secret
11648678	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/content-three.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/content-three.env	View secret
11648678	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/content-three.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`32419d7`	core/infra/dev_config/content-three.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/content-two.env	View secret
11648679	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/content-two.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/content-two.env	View secret
11648679	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/content-two.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`32419d7`	core/infra/dev_config/content-two.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/content-one.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`12bdddd`	core/infra/dev_config/content-one.env	View secret
11648680	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/content-one.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`bdb7e40`	core/infra/dev_config/content-one.env	View secret
11648680	Triggered	Generic High Entropy Secret	`32419d7`	core/infra/dev_config/content-one.docker.env	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-06T18:58:25Z

Preview this change https://demo.audius.co/is-comment-actions

DejayJD · 2024-08-06T22:00:33Z

packages/libs/src/sdk/services/EntityManager/types.ts

  TIP = 'Tip',
-  COMMENT = 'Comment'
+  COMMENT = 'Comment',
+  REACTION = 'Reaction'


Do you think it makes sense to prefix COMMENT_REACTION instead? Since reactions in this context are just for comments

this isn't actually used, ill remove

DejayJD · 2024-08-06T22:53:26Z

packages/discovery-provider/src/tasks/entity_manager/entity_manager.py

            for _, dashboard_wallet_json in dashboard_wallets
        }

+    logger.info(f"asdf entities_to_fetch {entities_to_fetch}")


are these asdf logs meant to stay or just temporary

this is my trademark

DejayJD · 2024-08-06T22:54:11Z

packages/libs/src/sdk/api/comments/CommentsAPI.ts

+  async editComment(metadata: CommentMetadata) {
+    const { userId, entityId } = metadata
+    const response = await this.entityManager.manageEntity({
+      userId,
+      entityType: EntityType.COMMENT,
+      entityId,
+      action: Action.UPDATE,
+      metadata: JSON.stringify({
+        cid: '',
+        data: snakecaseKeys(metadata)
+      }),
+      auth: this.auth
+    })
+    return response
+  }


man I love how simple these methods are in the SDK

DejayJD

LGTM - minus the debug logs that I assume need to be deleted

audius-infra · 2024-08-07T20:07:15Z

Preview this change https://demo.audius.co/is-comment-actions

[5ed523f] Add comment actions: edit, delete, react (#9372) Isaac Solo [74c7a03] Clean up old trending versions (#9388) Raymond Jacobson [d7f24a4] [QA-1459] Fix broken slugs (#9396) Raymond Jacobson

[7121301] Set is_custom_musical_key (#9418) Sebastian Klingler [ee99fd4] add is_custom_musical_key (#9416) Michelle Brier [f30a637] [PAY-3332] Remixers users endpoint (#9401) Reed [f2eabb1] [QA-1491] Fix balance polling bug (#9402) Raymond Jacobson [c5e7348] Fix lint (#9412) Raymond Jacobson [5598656] [QA-1356] Improve notification UI (#9390) Raymond Jacobson [dcb74eb] Fix useClickOutside (#9409) Andrew Mendelsohn [975b630] Add better error messages for Claimable Tokens Program (#9369) Marcus Pasell [17904fb] [PAY-3335] Add priority fees to SDK Solana usages (#9399) Marcus Pasell [c34cd83] Record Track Downloads via Entity Manager (#9103) Marcus Pasell [e59dfc8] [QA-1357] Remove excessive polling and amplitude events in unlock (#9391) Raymond Jacobson [26b2fc9] [QA-1496] fix unsafe read of audio analysis field (#9406) Randy Schott [abc1b37] [C-4934] Search bar fixes (#9403) Sebastian Klingler [d525a1b] [C-4930, C-4931] Add IconText, ArtistPick, and Identifier components to harmony and harmony native (#9400) Kyle Shanks [53bf3e2] [PAY-3321][PAY-3333] Add network cut feature flag and update staking bridge and payment router addresses (#9393) Saliou Diallo [4d0fbc2] [PAY-3294] Hide save/repost for locked albums on mobile (#9333) Reed [7e3a75c] [C-4936] FilterButton fixes (#9397) Sebastian Klingler [517251d] [PAY-3286] Upload/edit confirmation drawer & modal rework (#9326) Raymond Jacobson [dce9903] [C-4920] Only show bpm decimals if necessary (#9398) Sebastian Klingler [d6dbab0] [C-4937] Adding some pagination buttons (#9394) JD Francis [f183f7e] [PAY-3336] fix isPlaying logic for details screens (#9395) Randy Schott [5ed523f] Add comment actions: edit, delete, react (#9372) Isaac Solo [88e24b5] [C 4922] Update mobile filter button (#9385) Dylan Jeffers [901d811] [C-4923] Persist verified filter & general cleanup (#9384) Sebastian Klingler [bab49d6] Add Pin icon and Timestamp component to harmony and harmony-native (#9383) Kyle Shanks [53a1a32] [QA-1485] Redir to signup/in on direct /feed link (#9373) Raymond Jacobson [c618eb9] Improve useClickOutside (#9377) Sebastian Klingler [a97deb8] [PAY-2267] Update stage payment router and program addresses (#9387) Raymond Jacobson [def034f] [QA-1446] Fix popup alignment (#9389) Raymond Jacobson [c86bc70] Add priority fees to purchases (#9392) Marcus Pasell [66f1a0e] [PAY-3314] Track select dropdown for purchase/remix targeting (#9386) Andrew Mendelsohn [5fe7681] Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319) JD Francis [1ccfcd4] [PAY-3331] Purchase/sale endpoint filtering by content id (#9376) Reed [fc59a10] [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375) Raymond Jacobson [7712005] Fix short trending bug (#9378) Raymond Jacobson [196fdba] [QA-1114] Include menu items even if buttons are present (#9381) Raymond Jacobson [8e6b1e8] [QA-1486] Fix sign up select artists screen (#9371) Sebastian Klingler [34d4417] [PAY-3313] Targeted DMs CTA and modal (#9364) Andrew Mendelsohn [3a19003] [C-4921] Fix search v2 navigating back from profile (#9370) Sebastian Klingler [d266394] [C-4918] Improve harmony web FilterButton (#9366) Dylan Jeffers [4ef81a7] Bump mobile versions to 110 (#9367) Dylan Jeffers

DejayJD and others added 19 commits July 17, 2024 13:26

wip

64e39a4

lots of WIP - UI scaffolding, little bit of SDK & backend APIs

155af7c

Add hooks for all the things

a935d7b

Fix parent comment id and make timestamp work

a037426

basic working e2e

126a22f

working e2e replies

64a6c2c

working e2e replies

f26a15c

filter comment replies from parent comments

b7b46c6

Fix css with flag off

0b1a37a

UI cleanup & types cleanup

bd6f275

type cleanup

16304ff

UI tweaks, work with no moreBy tracks

9afaebb

Fixing types

74cd0c3

last bit of type changes

fbd6442

Edit UI working

c53d24a

wip

d575b7d

clean up discovery

541327f

Merge branch 'jd/comments-e2e-scaffolding' into is-comment-actions

bdb7e40

pull-request-size bot added the size/L label Aug 5, 2024

isaac added 3 commits August 5, 2024 14:13

lint discovery

9330d34

fix lint errors

bc25030

fix type

816f977

isaacsolo requested a review from DejayJD August 6, 2024 18:43

DejayJD reviewed Aug 6, 2024

View reviewed changes

Base automatically changed from jd/comments-e2e-scaffolding to main August 6, 2024 22:39

pull-request-size bot removed the size/L label Aug 6, 2024

pull-request-size bot added the size/XXL label Aug 6, 2024

Merge branch 'main' into is-comment-actions

32419d7

pull-request-size bot added size/XL and removed size/XXL labels Aug 6, 2024

DejayJD reviewed Aug 6, 2024

View reviewed changes

DejayJD approved these changes Aug 7, 2024

View reviewed changes

isaac added 3 commits August 7, 2024 12:18

small fixes

f03ee16

Merge branch 'main' into is-comment-actions

f9f503a

clean up sdk changes

4d00619

pull-request-size bot added size/L and removed size/XL labels Aug 7, 2024

isaacsolo merged commit 5ed523f into main Aug 7, 2024

isaacsolo deleted the is-comment-actions branch August 7, 2024 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add comment actions: edit, delete, react #9372

Add comment actions: edit, delete, react #9372

Uh oh!

isaacsolo commented Aug 5, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 5, 2024 •

edited

Loading

Uh oh!

gitguardian bot commented Aug 5, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 6, 2024

Uh oh!

DejayJD Aug 6, 2024 •

edited

Loading

Uh oh!

isaacsolo Aug 7, 2024

Uh oh!

DejayJD Aug 6, 2024 •

edited

Loading

Uh oh!

isaacsolo Aug 7, 2024

Uh oh!

DejayJD Aug 6, 2024

Uh oh!

DejayJD left a comment

Uh oh!

audius-infra commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add comment actions: edit, delete, react #9372

Add comment actions: edit, delete, react #9372

Uh oh!

Conversation

isaacsolo commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardian bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Aug 6, 2024

Uh oh!

DejayJD Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaacsolo Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaacsolo Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD left a comment

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

isaacsolo commented Aug 5, 2024 •

edited

Loading

changeset-bot bot commented Aug 5, 2024 •

edited

Loading

gitguardian bot commented Aug 5, 2024 •

edited

Loading

DejayJD Aug 6, 2024 •

edited

Loading

DejayJD Aug 6, 2024 •

edited

Loading