[C-4918] Improve harmony web FilterButton #9366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2070c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Preview this change https://demo.audius.co/c-4918-filter-button |
sliptype
approved these changes
Aug 5, 2024
Contributor
sliptype
left a comment
sliptype
left a comment
There was a problem hiding this comment.
Amazing work, thank you for cleaning this all up!
|
|
||
| return ( | ||
| <BaseButton | ||
| ref={mergeRefs([ref, anchorRef])} |
| aria-label={selectedLabel ?? label ?? props['aria-label']} | ||
| aria-activedescendant={selectedLabel} | ||
| > | ||
| {showFilterInput && filterInputProps ? ( |
Contributor
There was a problem hiding this comment.
filterInputProps is required to show the filter input?
Contributor
Author
There was a problem hiding this comment.
since label is required, what you think?
Contributor
There was a problem hiding this comment.
Gotcha, maybe just a comment on the type to call that out. We could even write the type so it requires filterInputProps when showFilterInput is true, but that may be overkill
| required && hideLabel ? `${placeholder} *` : placeholder | ||
| required && hideLabel | ||
| ? `${placeholder} *` | ||
| : TextInputSize.SMALL |
Contributor
There was a problem hiding this comment.
Probably meant to do a comparison here
| label={label} | ||
| onChange={updateSearchParams} | ||
| iconRight={IconCaretDown} | ||
| popupProps={{ |
Contributor
There was a problem hiding this comment.
Much nicer that we don't have to manually specify the Popup now
| <Divider css={{ width: '100%' }} /> | ||
| <Flex direction='column' w='100%' ph='s'> | ||
| <FilterButtonOptions | ||
| activeValue={activeValue} |
Contributor
There was a problem hiding this comment.
activeValue should work by default now right? This was added so a value coming from the url is highlighted in the options when the filter popup is opened
Contributor
Author
There was a problem hiding this comment.
yeah let me confirm if that's needed, i think it should just worked based on "value" now
| * What to do when the value is changed | ||
| */ | ||
| onChange?: (value: string) => void | ||
| onChange?: (value: Value) => void |
Contributor
There was a problem hiding this comment.
Did we not want to turn this into a change event?
audius-infra
pushed a commit
that referenced
this pull request
Aug 10, 2024
[7121301] Set is_custom_musical_key (#9418) Sebastian Klingler [ee99fd4] add is_custom_musical_key (#9416) Michelle Brier [f30a637] [PAY-3332] Remixers users endpoint (#9401) Reed [f2eabb1] [QA-1491] Fix balance polling bug (#9402) Raymond Jacobson [c5e7348] Fix lint (#9412) Raymond Jacobson [5598656] [QA-1356] Improve notification UI (#9390) Raymond Jacobson [dcb74eb] Fix useClickOutside (#9409) Andrew Mendelsohn [975b630] Add better error messages for Claimable Tokens Program (#9369) Marcus Pasell [17904fb] [PAY-3335] Add priority fees to SDK Solana usages (#9399) Marcus Pasell [c34cd83] Record Track Downloads via Entity Manager (#9103) Marcus Pasell [e59dfc8] [QA-1357] Remove excessive polling and amplitude events in unlock (#9391) Raymond Jacobson [26b2fc9] [QA-1496] fix unsafe read of audio analysis field (#9406) Randy Schott [abc1b37] [C-4934] Search bar fixes (#9403) Sebastian Klingler [d525a1b] [C-4930, C-4931] Add IconText, ArtistPick, and Identifier components to harmony and harmony native (#9400) Kyle Shanks [53bf3e2] [PAY-3321][PAY-3333] Add network cut feature flag and update staking bridge and payment router addresses (#9393) Saliou Diallo [4d0fbc2] [PAY-3294] Hide save/repost for locked albums on mobile (#9333) Reed [7e3a75c] [C-4936] FilterButton fixes (#9397) Sebastian Klingler [517251d] [PAY-3286] Upload/edit confirmation drawer & modal rework (#9326) Raymond Jacobson [dce9903] [C-4920] Only show bpm decimals if necessary (#9398) Sebastian Klingler [d6dbab0] [C-4937] Adding some pagination buttons (#9394) JD Francis [f183f7e] [PAY-3336] fix isPlaying logic for details screens (#9395) Randy Schott [5ed523f] Add comment actions: edit, delete, react (#9372) Isaac Solo [88e24b5] [C 4922] Update mobile filter button (#9385) Dylan Jeffers [901d811] [C-4923] Persist verified filter & general cleanup (#9384) Sebastian Klingler [bab49d6] Add Pin icon and Timestamp component to harmony and harmony-native (#9383) Kyle Shanks [53a1a32] [QA-1485] Redir to signup/in on direct /feed link (#9373) Raymond Jacobson [c618eb9] Improve useClickOutside (#9377) Sebastian Klingler [a97deb8] [PAY-2267] Update stage payment router and program addresses (#9387) Raymond Jacobson [def034f] [QA-1446] Fix popup alignment (#9389) Raymond Jacobson [c86bc70] Add priority fees to purchases (#9392) Marcus Pasell [66f1a0e] [PAY-3314] Track select dropdown for purchase/remix targeting (#9386) Andrew Mendelsohn [5fe7681] Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319) JD Francis [1ccfcd4] [PAY-3331] Purchase/sale endpoint filtering by content id (#9376) Reed [fc59a10] [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375) Raymond Jacobson [7712005] Fix short trending bug (#9378) Raymond Jacobson [196fdba] [QA-1114] Include menu items even if buttons are present (#9381) Raymond Jacobson [8e6b1e8] [QA-1486] Fix sign up select artists screen (#9371) Sebastian Klingler [34d4417] [PAY-3313] Targeted DMs CTA and modal (#9364) Andrew Mendelsohn [3a19003] [C-4921] Fix search v2 navigating back from profile (#9370) Sebastian Klingler [d266394] [C-4918] Improve harmony web FilterButton (#9366) Dylan Jeffers [4ef81a7] Bump mobile versions to 110 (#9367) Dylan Jeffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates OptionsFilterButton and FilterButton
Replaces various popover props with
popoverPropsReplaces filterInputPlaceholder with
filterInputPropsMakes Value generic, helping with some enum / union types
Updates all usages
mobile FilterButton changes in a separate PR