Skip to content

Conversation

@rickyrombo
Copy link
Contributor

Description

  • Adds minimum fees for each SDK call
  • Adds percentile based fees for each SDK call
  • Fixes percentile calculation (sort() does ascii sort 😂 )

Arbitrarily chose minimums of 150k micro lamports for purchases, 100k for tips, 100k for challenges, and 100k for payout wallet creation. Chose VERY_HIGH as default for all (95%)

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 8c7dfbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@audius/sdk Patch
@audius/sp-actions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!!! though i'm not sure why we really need to vary the minimums on these. I think 150K is probably good for all of them 🤷 probably doesn't matter tho

@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 9, 2024
@rickyrombo rickyrombo enabled auto-merge (squash) August 9, 2024 00:30
@rickyrombo rickyrombo merged commit 17904fb into main Aug 9, 2024
@rickyrombo rickyrombo deleted the mjp-priorities-2 branch August 9, 2024 00:55
audius-infra pushed a commit that referenced this pull request Aug 10, 2024
[7121301] Set is_custom_musical_key (#9418) Sebastian Klingler
[ee99fd4] add is_custom_musical_key (#9416) Michelle Brier
[f30a637] [PAY-3332] Remixers users endpoint (#9401) Reed
[f2eabb1] [QA-1491] Fix balance polling bug (#9402) Raymond Jacobson
[c5e7348] Fix lint (#9412) Raymond Jacobson
[5598656] [QA-1356] Improve notification UI (#9390) Raymond Jacobson
[dcb74eb] Fix useClickOutside (#9409) Andrew Mendelsohn
[975b630] Add better error messages for Claimable Tokens Program (#9369) Marcus Pasell
[17904fb] [PAY-3335] Add priority fees to SDK Solana usages (#9399) Marcus Pasell
[c34cd83] Record Track Downloads via Entity Manager (#9103) Marcus Pasell
[e59dfc8] [QA-1357] Remove excessive polling and amplitude events in unlock (#9391) Raymond Jacobson
[26b2fc9] [QA-1496] fix unsafe read of audio analysis field (#9406) Randy Schott
[abc1b37] [C-4934] Search bar fixes (#9403) Sebastian Klingler
[d525a1b] [C-4930, C-4931] Add IconText, ArtistPick, and Identifier components to harmony and harmony native (#9400) Kyle Shanks
[53bf3e2] [PAY-3321][PAY-3333] Add network cut feature flag and update staking bridge and payment router addresses (#9393) Saliou Diallo
[4d0fbc2] [PAY-3294] Hide save/repost for locked albums on mobile (#9333) Reed
[7e3a75c] [C-4936] FilterButton fixes (#9397) Sebastian Klingler
[517251d] [PAY-3286] Upload/edit confirmation drawer & modal rework (#9326) Raymond Jacobson
[dce9903] [C-4920] Only show bpm decimals if necessary (#9398) Sebastian Klingler
[d6dbab0] [C-4937] Adding some pagination buttons (#9394) JD Francis
[f183f7e] [PAY-3336] fix isPlaying logic for details screens (#9395) Randy Schott
[5ed523f] Add comment actions: edit, delete, react (#9372) Isaac Solo
[88e24b5] [C 4922] Update mobile filter button (#9385) Dylan Jeffers
[901d811] [C-4923] Persist verified filter & general cleanup (#9384) Sebastian Klingler
[bab49d6] Add Pin icon and Timestamp component to harmony and harmony-native (#9383) Kyle Shanks
[53a1a32] [QA-1485] Redir to signup/in on direct /feed link (#9373) Raymond Jacobson
[c618eb9] Improve useClickOutside (#9377) Sebastian Klingler
[a97deb8] [PAY-2267] Update stage payment router and program addresses (#9387) Raymond Jacobson
[def034f] [QA-1446] Fix popup alignment (#9389) Raymond Jacobson
[c86bc70] Add priority fees to purchases (#9392) Marcus Pasell
[66f1a0e] [PAY-3314] Track select dropdown for purchase/remix targeting (#9386) Andrew Mendelsohn
[5fe7681] Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319) JD Francis
[1ccfcd4] [PAY-3331] Purchase/sale endpoint filtering by content id (#9376) Reed
[fc59a10] [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375) Raymond Jacobson
[7712005] Fix short trending bug (#9378) Raymond Jacobson
[196fdba] [QA-1114] Include menu items even if buttons are present (#9381) Raymond Jacobson
[8e6b1e8] [QA-1486] Fix sign up select artists screen (#9371) Sebastian Klingler
[34d4417] [PAY-3313] Targeted DMs CTA and modal (#9364) Andrew Mendelsohn
[3a19003] [C-4921] Fix search v2 navigating back from profile (#9370) Sebastian Klingler
[d266394] [C-4918] Improve harmony web FilterButton (#9366) Dylan Jeffers
[4ef81a7] Bump mobile versions to 110 (#9367) Dylan Jeffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants