Skip to content

Conversation

@dharit-tan
Copy link
Contributor

Description

Something changed on the tx we send for purchases, it now includes geo:null as the memo data for the geo memo. We could try to not send the memo when performing purchases on local stack, or we could skip the geo step on local stack which is what this PR does. Either way is unclean so figured it doesn't make a difference.

How Has This Been Tested?

Local purchase successfully indexed

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 8e3780c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

if memo.startswith(GEO_MEMO_STRING):
if (
memo.startswith(GEO_MEMO_STRING)
and shared_config["discprov"]["env"] != "dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to more gracefully handle if there isn't geo data even outside of dev - if this throws it makes payment indexing get stuck. Maybe instead of throwing we should log an error and skip the geo info reporting?

@dharit-tan dharit-tan requested a review from rickyrombo August 26, 2024 17:59
@dharit-tan dharit-tan merged commit 84f4781 into main Aug 26, 2024
@dharit-tan dharit-tan deleted the rt-geo branch August 26, 2024 18:38
audius-infra pushed a commit that referenced this pull request Aug 27, 2024
[eed6296] Fix include_network_cut parameter (#9555) Marcus Pasell
[48b8641] Fix purchasers endpoint (#9549) Andrew Mendelsohn
[53deb4b] Remove marshalling for nft-gated-signatures (#9550) Randy Schott
[6b170d0] [PAY-3375] get chat endpoint correctly filters for audience:type:id (#9545) Steve Perkins
[84f4781] [PAY-3380] Skip geo indexing on local dev stack (#9544) Reed
[ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants