Skip to content

Conversation

@amendelsohn
Copy link
Contributor

Description

Calling .all() before calling add_query_pagination meant we were passing a list of results as the query arg to add_query_pagination. Calling .limit() failed because it wasn't being called on a query.

Also note that we're already calling .all() in this line below after adding pagination:

rows = add_query_pagination(query, limit, offset).all()

How Has This Been Tested?

working on local stack

@amendelsohn amendelsohn requested a review from dharit-tan August 26, 2024 19:53
@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 69b0405

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dharit-tan dharit-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dohhhhh tysm!

@amendelsohn amendelsohn merged commit 48b8641 into main Aug 26, 2024
@amendelsohn amendelsohn deleted the am-fix-purchasers branch August 26, 2024 23:59
audius-infra pushed a commit that referenced this pull request Aug 27, 2024
[eed6296] Fix include_network_cut parameter (#9555) Marcus Pasell
[48b8641] Fix purchasers endpoint (#9549) Andrew Mendelsohn
[53deb4b] Remove marshalling for nft-gated-signatures (#9550) Randy Schott
[6b170d0] [PAY-3375] get chat endpoint correctly filters for audience:type:id (#9545) Steve Perkins
[84f4781] [PAY-3380] Skip geo indexing on local dev stack (#9544) Reed
[ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants