Remove marshalling for nft-gated-signatures #9550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the numerical keys
|
rickyrombo
approved these changes
Aug 26, 2024
raymondjacobson
approved these changes
Aug 26, 2024
audius-infra
pushed a commit
that referenced
this pull request
Aug 27, 2024
[eed6296] Fix include_network_cut parameter (#9555) Marcus Pasell [48b8641] Fix purchasers endpoint (#9549) Andrew Mendelsohn [53deb4b] Remove marshalling for nft-gated-signatures (#9550) Randy Schott [6b170d0] [PAY-3375] get chat endpoint correctly filters for audience:type:id (#9545) Steve Perkins [84f4781] [PAY-3380] Skip geo indexing on local dev stack (#9544) Reed [ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wasn't able to test this correctly and it bit me!
The keys in the
dictthat comes back from the db query are numbers. The type we were using for marshaling (Wildcard) only works with strings. So attempting to marshal was throwing an exception.However, since this is a very simple object that doesn't require any transformation, we can get by with just specifying the response type for documentation sake (and generating SDK code) and then return the response without attempting to marshal it. It gets
jsonify-d anyway, and the numbers will be converted to strings as part of that process. Prior to client SDK migration, this is what we were doing.How Has This Been Tested?
Spun up a local stack and got a user created with an NFT-connected wallet. Uploaded a NFT-gated track. Checked access to said track to make sure the endpoint was functioning again.