Fix include_network_cut parameter #9555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
raymondjacobson
approved these changes
Aug 27, 2024
| price = gate.get("usdc_purchase", {}).get("price", None) | ||
| splits = gate.get("usdc_purchase", {}).get("splits", []) | ||
| original_splits = gate.get("usdc_purchase", {}).get("splits", []) | ||
| splits = [orig.copy() for orig in original_splits] |
Member
There was a problem hiding this comment.
do we want to deep copy here just in case this gets more complex?
Contributor
Author
There was a problem hiding this comment.
maybe? though that's a 20x perf hit so idk if it's worth it yet
audius-infra
pushed a commit
that referenced
this pull request
Aug 27, 2024
[eed6296] Fix include_network_cut parameter (#9555) Marcus Pasell [48b8641] Fix purchasers endpoint (#9549) Andrew Mendelsohn [53deb4b] Remove marshalling for nft-gated-signatures (#9550) Randy Schott [6b170d0] [PAY-3375] get chat endpoint correctly filters for audience:type:id (#9545) Steve Perkins [84f4781] [PAY-3380] Skip geo indexing on local dev stack (#9544) Reed [ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
access-infoendpoint_get_extended_purchase_gate()method was mutating the passed in "gate" info splits, causing the amounts to be wrong for theaccess-infoendpoint.How Has This Been Tested?
Tested that the endpoint returns as expected when run locally. Still need to test E2E, but need to deploy a "staking bridge" (probably just default to the local owner wallet) locally first