Skip to content

Track context menus should be accessible from anywhere in the track, fixes #3947#5562

Merged
fqueze merged 2 commits intofirefox-devtools:mainfrom
fqueze:track-context
Sep 15, 2025
Merged

Track context menus should be accessible from anywhere in the track, fixes #3947#5562
fqueze merged 2 commits intofirefox-devtools:mainfrom
fqueze:track-context

Conversation

@fqueze
Copy link
Contributor

@fqueze fqueze commented Aug 22, 2025

I almost opened a duplicate of #3947 today, so I figured it was time to look at how much effort it would take to fix it.

Example profile with a network and IPC tracks: https://share.firefox.dev/3HKzqKf
deploy preview

@fqueze fqueze requested a review from canova August 22, 2025 15:06
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.84%. Comparing base (ddd385e) to head (5e737cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5562   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         309      309           
  Lines       30336    30336           
  Branches     8348     8350    +2     
=======================================
  Hits        26041    26041           
  Misses       3874     3874           
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fqueze fqueze enabled auto-merge (squash) September 10, 2025 14:20
@fqueze fqueze merged commit da1ad17 into firefox-devtools:main Sep 15, 2025
12 of 13 checks passed
canova added a commit that referenced this pull request Sep 16, 2025
Changes:

[Markus Stange] Switch CSS back to using relative paths inside url(...)
(#5594)
[Markus Stange] Use dynamic imports for jszip (#5593)
[Florian Quèze] Allow markers to provide a marker color. (#5607)
[Ryan Hunt] Update iongraph-web to latest version (#5606)
[Florian Quèze] Fix the color contrast of hovered colored markers.
(#5609)
[Florian Quèze] Scale custom marker graphs on values within the
committed range. (#5587)
[Markus Stange] Fix null marker stack substitution (#5613)
[Florian Quèze] Track context menus should be accessible from anywhere
in the track (#5562)
[Markus Stange] Worker + compression cleanups (#5602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants