Fix null marker stack substitution#5613
Merged
mstange merged 2 commits intofirefox-devtools:mainfrom Sep 14, 2025
Merged
Conversation
We want stack-less "causes" whenever we want to filter out a stack completely, for example because it doesn't contain the focused function when we're applying a focus function transform. Pre-TypeScript, we were already using this field that way, even though it wasn't typed correctly.
We need to replace cause.stack even if convertStack returned null, otherwise we have bad stack indexes sticking around. The incorrect `if (stack)` was added during the TypeScript migration in commit ed02f3f. This restores the logic as it was before the migration.
mstange
force-pushed
the
fix-null-marker-stack-substitution
branch
from
548b7b7 to
124cf1d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5613 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 309 309
Lines 30426 30424 -2
Branches 8371 8371
=======================================
- Hits 26112 26111 -1
+ Misses 3893 3892 -1
Partials 421 421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
added a commit
that referenced
this pull request
Sep 16, 2025
Changes: [Markus Stange] Switch CSS back to using relative paths inside url(...) (#5594) [Markus Stange] Use dynamic imports for jszip (#5593) [Florian Quèze] Allow markers to provide a marker color. (#5607) [Ryan Hunt] Update iongraph-web to latest version (#5606) [Florian Quèze] Fix the color contrast of hovered colored markers. (#5609) [Florian Quèze] Scale custom marker graphs on values within the committed range. (#5587) [Markus Stange] Fix null marker stack substitution (#5613) [Florian Quèze] Track context menus should be accessible from anywhere in the track (#5562) [Markus Stange] Worker + compression cleanups (#5602)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example with Focus function transform: Production | Deploy preview
Example with JS-only view: Production | Deploy preview
Fixes #5612.
The more stringent array bounds checks from #5599 revealed a bug that I introduced in #5549: Marker stacks were not being substituted if the
convertStacklambda returned null. This PR fixes the type and restores the working code from before the TypeScript migration.