Skip to content

Fix the color contrast of hovered colored markers.#5609

Merged
fqueze merged 3 commits intofirefox-devtools:mainfrom
fqueze:contrast-hovered-colored-marker
Sep 10, 2025
Merged

Fix the color contrast of hovered colored markers.#5609
fqueze merged 3 commits intofirefox-devtools:mainfrom
fqueze:contrast-hovered-colored-marker

Conversation

@fqueze
Copy link
Contributor

@fqueze fqueze commented Sep 9, 2025

Follow-up to #5607.

Deploy preview

@fqueze fqueze requested a review from mstange September 9, 2025 09:20
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.81%. Comparing base (5eed56e) to head (312e0c1).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/graph-color.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5609      +/-   ##
==========================================
- Coverage   85.82%   85.81%   -0.01%     
==========================================
  Files         309      309              
  Lines       30409    30413       +4     
  Branches     8370     8370              
==========================================
+ Hits        26099    26100       +1     
- Misses       3889     3892       +3     
  Partials      421      421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Markus Stange <markus.stange@gmail.com>
@fqueze fqueze enabled auto-merge (squash) September 10, 2025 14:48
@fqueze fqueze merged commit 2166b4a into firefox-devtools:main Sep 10, 2025
12 of 13 checks passed
canova added a commit that referenced this pull request Sep 16, 2025
Changes:

[Markus Stange] Switch CSS back to using relative paths inside url(...)
(#5594)
[Markus Stange] Use dynamic imports for jszip (#5593)
[Florian Quèze] Allow markers to provide a marker color. (#5607)
[Ryan Hunt] Update iongraph-web to latest version (#5606)
[Florian Quèze] Fix the color contrast of hovered colored markers.
(#5609)
[Florian Quèze] Scale custom marker graphs on values within the
committed range. (#5587)
[Markus Stange] Fix null marker stack substitution (#5613)
[Florian Quèze] Track context menus should be accessible from anywhere
in the track (#5562)
[Markus Stange] Worker + compression cleanups (#5602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants