Merged
Conversation
esbuild doesn't respect aliases for url() references in CSS files. We could add a plugin which implements this mapping but it seems fine to just change this to use relative URLs.
…rker.js. This allows us to keep the worker file located close to the file which uses it. It also makes it easier to have equivalent handling in esbuild.
I r+ed their removal in #5584 because node supports CompressionStream, but I forgot to ask for the fallbacks to be put back when we switched back to using a worker.
This is basically picking the opposite direction of #5581. With esbuild you can configure aliases, but it only respects them for imports into JS. It doesn't respect the aliases for url() references in CSS files. We could add a plugin which implements this mapping but it seems easier (and maybe more idiomatic) to just change our CSS to use relative URLs.
Once we switch to esbuild, this will fix #817. With Webpack it doesn't appear to quite do it, maybe because of the type imports. Bundle chunking with esbuild after this fix: <img width="3120" height="1600" alt="Screenshot 2025-09-04 at 10 42 21 AM" src="https://github.com/user-attachments/assets/d1579b79-4052-408e-9adf-25def19f74e5" />
iongraph now supports passing in line timings, so do that. Also use the migration API.
iongraph now supports passing in line timings, so do that. Also use the migration API.
We want stack-less "causes" whenever we want to filter out a stack completely, for example because it doesn't contain the focused function when we're applying a focus function transform. Pre-TypeScript, we were already using this field that way, even though it wasn't typed correctly.
We need to replace cause.stack even if convertStack returned null, otherwise we have bad stack indexes sticking around. The incorrect `if (stack)` was added during the TypeScript migration in commit ed02f3f. This restores the logic as it was before the migration.
Example with Focus function transform: [Production](https://share.firefox.dev/4mW78M3) | [Deploy preview](https://deploy-preview-5613--perf-html.netlify.app/public/ggqb1y28h0nmwyxaqjdhvrnmfpn58hyeg25cza8/calltree/?globalTrackOrder=q0phkm7in1c9f5g862boela34dj&hiddenGlobalTracks=1wo&hiddenLocalTracksByPid=2465-1w4~92294-0~36702-0~2523-0~36259-0w2~71663-01~71664-0&search=oae&thread=x6&transforms=ff-280&v=11) Example with JS-only view: [Production](https://share.firefox.dev/4poRI4M) | [Deploy preview](https://deploy-preview-5613--perf-html.netlify.app/public/rpnres9s7rdrsfb240wtskvrq5sv7xzn3f4m2p0/calltree/?globalTrackOrder=30w2&hiddenGlobalTracks=01&hiddenLocalTracksByPid=2588-1w3~2591-01&implementation=js&range=9133m2135~9517m70&search=aoeu&tabID=25&thread=f&v=11) Fixes #5612. The more stringent array bounds checks from #5599 revealed a bug that I introduced in #5549: Marker stacks were not being substituted if the `convertStack` lambda returned null. This PR fixes the type and restores the working code from before the TypeScript migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
[Markus Stange] Switch CSS back to using relative paths inside url(...) (#5594)
[Markus Stange] Use dynamic imports for jszip (#5593)
[Florian Quèze] Allow markers to provide a marker color. (#5607)
[Ryan Hunt] Update iongraph-web to latest version (#5606)
[Florian Quèze] Fix the color contrast of hovered colored markers. (#5609)
[Florian Quèze] Scale custom marker graphs on values within the committed range. (#5587)
[Markus Stange] Fix null marker stack substitution (#5613)
[Florian Quèze] Track context menus should be accessible from anywhere in the track (#5562)
[Markus Stange] Worker + compression cleanups (#5602)