Skip to content

Conversation

@sddioulde
Copy link
Contributor

@sddioulde sddioulde commented Aug 8, 2024

Description

Left to do in this PR:

  • callers of get_legacy_purchase_gate should pass in the include_network_cut conditionally
  • payment indexing should validate staking bridge usdc payout wallet if network cut is included in transaction
  • update staking_bridge_usdc_payout_wallet in DN config
  • from libs folder run npm run gen:dev to update sdk types
  • test end-to-end flow e.g. make track purchase from client

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@gitguardian
Copy link

gitguardian bot commented Aug 8, 2024

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/discovery-one.env View secret
11648676 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/discovery-one.docker.env View secret
11648678 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/content-three.docker.env View secret
11648678 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/content-three.env View secret
11648679 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/content-two.docker.env View secret
11648679 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/content-two.env View secret
11648680 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/content-one.docker.env View secret
11648680 Triggered Generic High Entropy Secret 3e625d2 core/infra/dev_config/content-one.env View secret
13407071 Triggered Generic High Entropy Secret 3e625d2 comms/Makefile View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 9ac60e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sd-network-cut2

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sd-network-cut2

@sddioulde sddioulde changed the title [PAY-3315][PAY-3323] WIP [PAY-3315][PAY-3316][PAY-3323] WIP Aug 9, 2024
@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sd-network-cut2

Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@raymondjacobson raymondjacobson changed the title [PAY-3315][PAY-3316][PAY-3323] WIP [PAY-3315][PAY-3316][PAY-3323] Staking bridge Aug 14, 2024
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sd-network-cut2

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/sd-network-cut2

@raymondjacobson raymondjacobson merged commit aca7b5c into main Aug 16, 2024
@raymondjacobson raymondjacobson deleted the sd-network-cut2 branch August 16, 2024 21:09
audius-infra pushed a commit that referenced this pull request Aug 17, 2024
[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis
[641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis
[aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo
[bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis
[3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson
[8c127d0] Add comment replies pagination (#9435) Isaac Solo
[c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks
[a17b30e] Hook up client blast params to sdk (#9466) Reed
[11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed
[bcaebb0] fix TS error (#9468) JD Francis
[bb802b7] Optimistic add chat blasts (#9463) Reed
[b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott
[d4c34c3] Fix comment delete in audius-query (#9462) JD Francis
[95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler
[fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott
[2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed
[279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins
[acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson
[c382e82] Don't decrypt plaintext messages (#9448) Reed
[172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson
[82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson
[363af71] Compose Solana Client in SDK (#9441) Marcus Pasell
[83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn
[19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins
[e25c679] Rename Targeted Message to Chat Blast (#9443) Reed
[fc0604c] [C-4964] Comment header changes (#9444) JD Francis
[f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed
[910b655] Move comments context to common (#9440) JD Francis
[bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis
[1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell
[1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler
[4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell
[54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins
[ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis
[20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott
[ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott
[f6ab71c] Add buy button metrics (#9428) Isaac Solo
[06ee8a1] Fix pagination args (#9425) Isaac Solo
[b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler
[a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks
audius-infra pushed a commit that referenced this pull request Aug 19, 2024
[aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo
[bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis
[8c127d0] Add comment replies pagination (#9435) Isaac Solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants