[PAY-3106][PAY-2914] Use SDK to withdraw USDC #9419

rickyrombo · 2024-08-09T23:30:25Z

Description

Fix for withdrawal swaps getting ratelimited on relay (currently breaking all withdrawals pretty sure)
Fix to only check instructions are allowed if signing the transaction
Implement proper signature verification on relay
Changes withdrawal swap transaction to use SDK (also pigeonholes it to USDC=>SOL but I think that's ok)
- Tempted to just rip this out entirely since it's dead code now?
Creates new method that uses simpler transactions for withdrawals
Updates Typescript for SDK to 5.4.5 from 5.0.4 (matches my VS Code plugin, fixes error with indexing arrays using an enum string)

How Has This Been Tested?

Still testing

changeset-bot · 2024-08-09T23:30:28Z

🦋 Changeset detected

Latest commit: 4ab1d3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@audius/sdk	Patch
@audius/sp-actions	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

audius-infra · 2024-08-10T00:03:29Z

Preview this change https://demo.audius.co/mjp-withdrawal-fixes

- Makes "mint" in SDK allow public keys as input - Refactors the transfer/recovery methods in audius-backend/solana to not need audius-backend at all and use SDK

audius-infra · 2024-08-12T19:09:57Z

Preview this change https://demo.audius.co/mjp-withdrawal-fixes

packages/web/src/services/solana/WithdrawUSDC.ts

audius-infra · 2024-08-12T20:48:22Z

Preview this change https://demo.audius.co/mjp-withdrawal-fixes

audius-infra · 2024-08-13T01:57:36Z

Preview this change https://demo.audius.co/mjp-withdrawal-fixes

...ider/plugins/pedalboard/apps/solana-relay/src/routes/relay/assertRelayAllowedInstructions.ts

packages/discovery-provider/plugins/pedalboard/apps/solana-relay/src/routes/relay/relay.ts

dharit-tan

lgtm!

schottra

Looks good. Does this need a changeset for SDK due to the mint argument changing type?

packages/common/src/services/audius-backend/solana.ts

schottra · 2024-08-13T19:43:41Z

packages/common/src/services/audius-backend/solana.ts

+      })
+    instructions.push(transferInstruction)
+
+    if (signer) {


nit: feels a little odd that the way you specify if there should be a prepare memo is by passing a signer? It's kind of a hidden side-effect.

agree... potentially could add a separate "memo" param alongside the optional signer. wdyt?

I think that makes a little more sense. I'm struggling to remember if we actually need the prepare memo to be signed? Signing memos is optional and I'm not sure if we really need to verify this particular piece of information since it's just used as metadata when we index.

packages/common/src/services/audius-backend/solana.ts

packages/common/src/store/buy-usdc/sagas.ts

packages/libs/src/sdk/utils/parseMintToken.ts

packages/web/src/services/solana/WithdrawUSDC.ts

schottra · 2024-08-13T19:53:36Z

packages/web/src/services/solana/solana.ts

-  const libs = await getLibs()
-  return libs.solanaWeb3Manager!.getConnection()
+  const sdk = await audiusSdk()
+  return sdk.services.claimableTokensClient.connection


I think I understood the *Client paradigm to be that you invoked a client for each program you interacted with. If that's true, I'm curious why the ClaimableTokens client is the one that gets used as the connection source for all solana interactions?

Yeah this sucks and I want to rewrite it. Initially I just had this initialize a new connection from the env. There's no "root" connection to pull out of SDK because each client is separately initted. I think the solve here is some "root" SolanaClient in SDK that each *Client is composed of rather than inheriting the BaseSolanaClient. Will take a stab at refactoring that.

Okay no worries for this PR. I just wanted to make sure I understood the intended design. I can totally see that since we need a root connection and we don't have a SolanaWeb3Manager in SDK, this is a compromise solution that gets us access to a connection when we need it.

packages/web/src/store/application/ui/withdraw-usdc/sagas.ts

packages/libs/src/sdk/utils/parseMintToken.ts

packages/web/src/services/solana/WithdrawUSDC.ts

packages/libs/package.json

packages/common/src/services/audius-backend/solana.ts

audius-infra · 2024-08-14T00:53:11Z

Preview this change https://demo.audius.co/mjp-withdrawal-fixes

[1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [3026411] Fix comment reactions pkey (#9433) Isaac Solo [13276d2] Format Solana Relay listens endpoint (#9429) Marcus Pasell

…ts-round-3 * origin/main: (23 commits) Audius Protocol v0.6.169 wrong core defaults (#9452) Don't decrypt plaintext messages (#9448) [QA-1495] Fix 404 for users (#9451) [PAY-3227] Unfurl tracks in composer (#9434) Compose Solana Client in SDK (#9441) Create ChatBlast from web (#9447) [PAY-3341] Add is_plaintext field for chat message (#9442) use const for constants (#9446) core default values (#9445) Rename Targeted Message to Chat Blast (#9443) [C-4964] Comment header changes (#9444) [PAY-3310] Chat blast function in sdk (#9436) Move comments context to common (#9440) [C-4910] Comments replys & deletes fixes (#9437) Audius Protocol v0.6.168 [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Add social signup feature flag (#9439) use comet repo and modd for hotreloading (#9431) Fix duplicate error name in sentry (#9430) ...

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

rickyrombo added 7 commits August 8, 2024 17:41

Fix withdrawal relays getting rate limited

c115779

Fix relay to only check instructions if signing

d148072

implement verifySignatures

c28e06f

add @noble/curves

3dab5aa

Change withdrawal swap to use SDK

f9a3899

add method to transfer out USDC w/ ATA creation

e97cd0e

simplify withdrawals and use SDK

307d76a

rickyrombo requested review from dharit-tan, raymondjacobson and schottra August 9, 2024 23:30

pull-request-size bot added the size/XL label Aug 9, 2024

rickyrombo added 5 commits August 9, 2024 16:39

add types

f80433f

error is default level

8b29898

update getConnection to use SDK

fa673a3

better amplitude error type

62a9401

rename to transferFrom

ea63d1d

rickyrombo added 4 commits August 11, 2024 23:19

Transfer and recovery for root wallet

c1822b1

- Makes "mint" in SDK allow public keys as input - Refactors the transfer/recovery methods in audius-backend/solana to not need audius-backend at all and use SDK

fix some types

2afe7ac

rename MintName => TokenName to avoid name conflict

a4c1296

rename helper output to mint / token

d7cb8fc

pull-request-size bot added size/XXL and removed size/XL labels Aug 12, 2024

rickyrombo commented Aug 12, 2024

View reviewed changes

packages/web/src/services/solana/WithdrawUSDC.ts Show resolved Hide resolved

add docstring

b912c15

Update typescript

0964eb1

rickyrombo changed the title ~~Mjp withdrawal fixes~~ [PAY-3106][PAY-2914] Use SDK to withdraw USDC Aug 13, 2024

dharit-tan reviewed Aug 13, 2024

View reviewed changes

...ider/plugins/pedalboard/apps/solana-relay/src/routes/relay/assertRelayAllowedInstructions.ts Show resolved Hide resolved

dharit-tan reviewed Aug 13, 2024

View reviewed changes

packages/discovery-provider/plugins/pedalboard/apps/solana-relay/src/routes/relay/relay.ts Show resolved Hide resolved

dharit-tan approved these changes Aug 13, 2024

View reviewed changes

schottra approved these changes Aug 13, 2024

View reviewed changes

raymondjacobson approved these changes Aug 13, 2024

View reviewed changes

rickyrombo added 7 commits August 13, 2024 17:14

fix log

648dd02

add deprecation

6a98f6e

comments

075f2cc

Only allow users to use our relay

4d334a4

getSDK()

54f32bd

better error messages for missing wallet

21a9d47

changeset

4ab1d3f

rickyrombo merged commit 1072f5a into main Aug 14, 2024

rickyrombo deleted the mjp-withdrawal-fixes branch August 14, 2024 01:42

rickyrombo mentioned this pull request Aug 26, 2024

[PAY-3348] Remove dead withdrawals code #9542

Merged

[PAY-3106][PAY-2914] Use SDK to withdraw USDC #9419

[PAY-3106][PAY-2914] Use SDK to withdraw USDC #9419

Uh oh!

Conversation

rickyrombo commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

audius-infra commented Aug 10, 2024

Uh oh!

audius-infra commented Aug 12, 2024

Uh oh!

Uh oh!

audius-infra commented Aug 12, 2024

Uh oh!

audius-infra commented Aug 13, 2024

Uh oh!

Uh oh!

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

schottra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

schottra Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

rickyrombo Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

schottra Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schottra Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

rickyrombo Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

schottra Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

rickyrombo Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rickyrombo commented Aug 9, 2024 •

edited

Loading

changeset-bot bot commented Aug 9, 2024 •

edited

Loading