[C-4964] Comment header changes #9444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sliptype
approved these changes
Aug 14, 2024
Contributor
sliptype
left a comment
sliptype
left a comment
There was a problem hiding this comment.
Nice! 100% agree on revisiting the hover. seems too hidden
| color='subdued' | ||
| ref={anchorRef} | ||
| css={{ | ||
| cursor: 'pointer', |
Contributor
There was a problem hiding this comment.
Weird that IconButton doesn't have pointer as default
Contributor
There was a problem hiding this comment.
yea i cant think of a reason that any button wouldn't have pointer as the default
Kyle-Shanks
approved these changes
Aug 14, 2024
Collaborator
|
Preview this change https://demo.audius.co/jd/comment-header |
schottra
added a commit
that referenced
this pull request
Aug 15, 2024
…ts-round-3 * origin/main: (23 commits) Audius Protocol v0.6.169 wrong core defaults (#9452) Don't decrypt plaintext messages (#9448) [QA-1495] Fix 404 for users (#9451) [PAY-3227] Unfurl tracks in composer (#9434) Compose Solana Client in SDK (#9441) Create ChatBlast from web (#9447) [PAY-3341] Add is_plaintext field for chat message (#9442) use const for constants (#9446) core default values (#9445) Rename Targeted Message to Chat Blast (#9443) [C-4964] Comment header changes (#9444) [PAY-3310] Chat blast function in sdk (#9436) Move comments context to common (#9440) [C-4910] Comments replys & deletes fixes (#9437) Audius Protocol v0.6.168 [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Add social signup feature flag (#9439) use comet repo and modd for hotreloading (#9431) Fix duplicate error name in sentry (#9430) ...
audius-infra
pushed a commit
that referenced
this pull request
Aug 17, 2024
[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to the CommentHeader.
Adds a popup menu that will be used to disable notifs. It shows on hover over the comment header but only for track owners (personally I think it could potentially be nice to have for non track owners, but this isnt currently in the spec and def lower priority for non track owners).
Also moved skeleton UI to its own component
Also need to discuss with design about the "hover" state; seems like it would be easy to miss so maybe we just skip hovering?
How Has This Been Tested?
web:stage