[PAY-3300] Chat blast: lazy create thread #9424

stereosteve · 2024-08-12T19:06:43Z

Description

Adds "chat blast" RPC. And some function around turning blasts into 1:1 messages when a dm thread exists between sender and recipient.

Also includes PAY-3202

This reverts commit ecce021.

changeset-bot · 2024-08-12T19:06:47Z

⚠️ No Changeset found

Latest commit: 839fba9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

comms/discovery/db/queries/get_new_blasts.go

dharit-tan · 2024-08-12T20:38:36Z

comms/discovery/rpcz/chat.go

+		values
+			($1, $2, $3, $4, $5)
+		on conflict do nothing
+		`, params.ChatID+blast.BlastID, params.ChatID, blast.FromUserID, ts, blast.BlastID)


ChatID + BlastID seems ok but making a note as it's different from our existing message IDs which are just ULIDs.

dharit-tan · 2024-08-12T20:39:34Z

comms/discovery/rpcz/chat.go

+	update chat c
+	set
+		last_message_at = latest.created_at,
+		last_message = coalesce(latest.ciphertext, '~' || latest.plaintext)


note that we'll have to use the is_encrypted boolean here too.

dharit-tan · 2024-08-12T20:42:18Z

packages/discovery-provider/ddl/migrations/0086_chat_blast.sql

+create table if not exists chat_blast (
+  blast_id text primary key,
+  from_user_id int not null,
+  audience text not null, -- todo sql enum I guess?


yeah i think enum

packages/discovery-provider/ddl/migrations/0086_chat_blast.sql

dharit-tan

lgtm! mind updating the PR desc to include the getNewBlasts endpoint too?

rickyrombo

One thing we'll want to do is make chat create's go through despite permissions if there's a chat blast from that user - something we don't have currently

comms/discovery/db/queries/get_new_blasts.go

rickyrombo · 2024-08-12T23:16:23Z

comms/discovery/db/queries/get_chat_messages.go

+	chat_message.chat_id,
+	chat_message.user_id,
+	chat_message.created_at,
+	COALESCE(chat_message.ciphertext, '~' || chat_blast.plaintext) as ciphertext, -- todo: separate out ciphertext + plaintext... make ciphertext nullable


Marking the todo w/ a CR comment

comms/discovery/db/queries/get_chat_messages.go

rickyrombo · 2024-08-12T23:19:47Z

comms/discovery/db/queries/get_chat_messages.go

+	chat_message.created_at,
+	COALESCE(chat_message.ciphertext, '~' || chat_blast.plaintext) as ciphertext, -- todo: separate out ciphertext + plaintext... make ciphertext nullable
+
+	to_json(array(select row_to_json(r) from chat_message_reactions r where chat_message.message_id = r.message_id)) AS reactions


interesting... why the switch?

also for consistency maybe capitalize the SQL keywords?

comms/discovery/db/queries/get_new_blasts.go

rickyrombo · 2024-08-12T23:24:28Z

comms/discovery/rpcz/chat.go


+	// first find any blasts that should seed this chat ...
+	// todo: do we have to do this in both directions?
+	// todo: do we have to do this for all audiences too?


rickyrombo · 2024-08-12T23:25:01Z

comms/discovery/rpcz/chat.go

+	// todo: do we have to do this in both directions?
+	// todo: do we have to do this for all audiences too?
+	//       if it is related to an `audience_track_id` we won't have that here...
+	//       so maybe the client can pass a separate param like `seed_blast_ids` to seed the thread context.


I don't think this matters - the blast itself will have the context

rickyrombo · 2024-08-12T23:25:16Z

comms/discovery/rpcz/chat.go

+	// todo: do we have to do this for all audiences too?
+	//       if it is related to an `audience_track_id` we won't have that here...
+	//       so maybe the client can pass a separate param like `seed_blast_ids` to seed the thread context.
+	// todo: should mark hidden for blaster


marking the todo with a PR comment

rickyrombo · 2024-08-12T23:26:12Z

comms/discovery/rpcz/chat.go

+	// todo: should mark hidden for blaster
+	blasts, err := queries.GetNewBlasts(tx, context.Background(), queries.ChatMembershipParams{
+		UserID: userId,
+		ChatID: params.ChatID, // ideally we'd just filter by chat ID which would get "both sides"... but the user id is required for the sql query... so maybe we make it so you can query by two user IDs or something...


not sure I understand this?

related to the "both directions done blasted" thing

comms/discovery/rpcz/chat.go

[1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [3026411] Fix comment reactions pkey (#9433) Isaac Solo [13276d2] Format Solana Relay listens endpoint (#9429) Marcus Pasell

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

stereosteve added 11 commits August 1, 2024 11:24

chat blast: fan out server impl

bbb81ba

half-done lazy chat creation stuff

f908b0f

Add blasts to existing chat if possible

c461fe3

Fix chat get test

32df625

gross changes to mix blasts in with /chats response

ecce021

chat blasts endpoint

12ab4e5

Fix join for adding blasts to existing chats

4d91386

Revert "gross changes to mix blasts in with /chats response"

dc0e3ca

This reverts commit ecce021.

/blasts endpoint only return blasts without existing chat

7c06afd

Chat blast will set last_message field

63731cf

plaintext comes back from messages endpoint

b5e0b27

pull-request-size bot added the size/XL label Aug 12, 2024

dharit-tan requested review from amendelsohn, dharit-tan and rickyrombo August 12, 2024 19:21

dharit-tan reviewed Aug 12, 2024

View reviewed changes

comms/discovery/db/queries/get_new_blasts.go Outdated Show resolved Hide resolved

dharit-tan reviewed Aug 12, 2024

View reviewed changes

packages/discovery-provider/ddl/migrations/0086_chat_blast.sql Outdated Show resolved Hide resolved

dharit-tan approved these changes Aug 12, 2024

View reviewed changes

rickyrombo reviewed Aug 12, 2024

View reviewed changes

PR feedback + more tests

839fba9

dharit-tan changed the title ~~Chat blast lazy~~ [PAY-3300] Chat blast lazy Aug 13, 2024

stereosteve changed the title ~~[PAY-3300] Chat blast lazy~~ [PAY-3300] Chat blast: lazy create thread Aug 13, 2024

stereosteve enabled auto-merge (squash) August 13, 2024 17:01

stereosteve merged commit 54a5a78 into main Aug 13, 2024

stereosteve deleted the chat-blast-lazy branch August 13, 2024 17:30

[PAY-3300] Chat blast: lazy create thread #9424

[PAY-3300] Chat blast: lazy create thread #9424

Uh oh!

Conversation

stereosteve commented Aug 12, 2024 • edited by dharit-tan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

changeset-bot bot commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

rickyrombo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stereosteve commented Aug 12, 2024 •

edited by dharit-tan

Loading

changeset-bot bot commented Aug 12, 2024 •

edited

Loading