Create ChatBlast from web #9447

amendelsohn · 2024-08-14T20:29:34Z

Description

Add ChatBlast type to sdk
Support both UserChat and ChatBlast in chats slice
Add createChatBlast saga
Add ChatListBlastItem to display chat on left sidebar for sender

How Has This Been Tested?

working end to end on local stack
create blast chat, type message, message appears in db

This reverts commit 9779b08.

changeset-bot · 2024-08-14T20:29:38Z

⚠️ No Changeset found

Latest commit: ee10038

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-08-14T20:29:39Z

⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11648676	Triggered	Generic High Entropy Secret	`de2b4a5`	core/infra/dev_config/discovery-one.docker.env	View secret
11648676	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/discovery-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/discovery-one.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`de2b4a5`	core/infra/dev_config/content-three.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/content-three.env	View secret
11648678	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/content-three.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`de2b4a5`	core/infra/dev_config/content-two.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/content-two.env	View secret
11648679	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/content-two.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`de2b4a5`	core/infra/dev_config/content-one.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/content-one.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`b25a9db`	core/infra/dev_config/content-one.env	View secret
13407071	Triggered	Generic High Entropy Secret	`fe8b607`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

dharit-tan · 2024-08-14T20:44:28Z

packages/common/src/store/pages/chat/sagas.ts

+      throw new Error('User not found')
+    }
+
+    const chatId = `${audience}${contentType ? `:${contentType}` : ''}${


should def pull this out to a helper somewhere but doesn't need to be this PR

rickyrombo · 2024-08-14T20:40:36Z

packages/common/src/store/pages/chat/sagas.ts

      !chat ||
-      !chat?.last_read_at ||
-      dayjs(chat?.last_read_at).isBefore(chat?.last_message_at)
+      (!chat.is_blast &&


I think we should early return if it's a blast - otherwise this falls through to the markChatAsReadFailed branch. I think it would also be easier to read.

rickyrombo · 2024-08-14T20:42:42Z

packages/common/src/store/pages/chat/selectors.ts

-      chatId ? getChat(state, chatId)?.recheck_permissions : false
+    (state: CommonState, { chatId }: { chatId: Maybe<string> }) => {
+      const chat = chatId ? getChat(state, chatId) : undefined
+      return chat?.is_blast ? true : !!chat?.recheck_permissions


chat?.is_blast || !!chat?.recheck_perimissions?

rickyrombo · 2024-08-14T20:43:50Z

packages/web/src/pages/chat-page/components/ChatBlastCTA.tsx

 }

-export const ChatBlastCTA = (props: ChatBlastCTAProps) => {
+export const TargetedMessageCTA = (props: TargetedMessageCTAProps) => {


Maybe leave this as ChatBlastCTA?

yeah this was an accident, good catch

dharit-tan · 2024-08-14T20:44:56Z

packages/common/src/store/pages/chat/sagas.ts

+    // } catch {}
+    const existingChat = yield* select((state) => getChat(state, chatId))
+    if (!existingChat) {
+      const newBlast: ChatBlast = {


nit: do we need the explicit type still?

yeah, removing it we need a cast later

dharit-tan · 2024-08-14T20:45:29Z

packages/common/src/store/pages/chat/sagas.ts

+      yield* call(track, make({ eventName: Name.CREATE_CHAT_SUCCESS }))
+    }
+  } catch (e) {
+    console.error('createChatFailed', e)


let's change this to createChatBlastFailed or something

dharit-tan · 2024-08-14T20:47:59Z

packages/common/src/store/pages/chat/sagas.ts

      !chat ||
-      !chat?.last_read_at ||
-      dayjs(chat?.last_read_at).isBefore(chat?.last_message_at)
+      (!chat.is_blast &&


hm this is hard to read...
but also, should it be that this entire if/else is wrapped in an outer if !chat.is_blast? we just don't want to do any mark as read stuff if it's a blast right?

dharit-tan · 2024-08-14T20:48:45Z

packages/common/src/store/pages/chat/selectors.ts

  // This really shouldn't be necessary since the above should be kept in sync
  const chats = getChats(state)
  for (const chat of chats) {
+    if (chat.is_blast) {


thinking out loud - maybe better pattern is to make a new selector getNonBlastChats or something. but this works for now.

dharit-tan · 2024-08-14T20:49:34Z

packages/common/src/store/pages/chat/slice.ts

 import { ChatWebsocketError } from './types'

-type UserChatWithMessagesStatus = UserChat & {
+export type Chat = UserChat | ChatBlast


@rickyrombo wdyt about this parent type naming?

Surprised there's no conflict with any types from SDK. I think when I wrote this I was mimicking the UserChallenge. I don't mind it tbh but if it gets confusing we can F2 rename it!

dharit-tan · 2024-08-14T20:50:17Z

packages/common/src/store/pages/chat/slice.ts

+      _action: PayloadAction<{
+        audience: ChatBlastAudience
+        contentId?: ID
+        contentType?: 'track' | 'album'


nit: 'track' | 'album' has gotta be a shared type somewhere right? 🤷

you would think, but we actually do this a lot

dharit-tan · 2024-08-14T20:50:42Z

packages/web/src/pages/chat-page/components/ChatBlastCTA.tsx

    onClick()
-    openChatBlastModal()
-  }, [onClick, openChatBlastModal])
+    openTargetedMessageModal()


uh-oh, merge main!

audius-infra · 2024-08-14T21:54:08Z

Preview this change https://demo.audius.co/rt-targeted

…ts-round-3 * origin/main: (23 commits) Audius Protocol v0.6.169 wrong core defaults (#9452) Don't decrypt plaintext messages (#9448) [QA-1495] Fix 404 for users (#9451) [PAY-3227] Unfurl tracks in composer (#9434) Compose Solana Client in SDK (#9441) Create ChatBlast from web (#9447) [PAY-3341] Add is_plaintext field for chat message (#9442) use const for constants (#9446) core default values (#9445) Rename Targeted Message to Chat Blast (#9443) [C-4964] Comment header changes (#9444) [PAY-3310] Chat blast function in sdk (#9436) Move comments context to common (#9440) [C-4910] Comments replys & deletes fixes (#9437) Audius Protocol v0.6.168 [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Add social signup feature flag (#9439) use comet repo and modd for hotreloading (#9431) Fix duplicate error name in sentry (#9430) ...

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

amendelsohn and others added 12 commits May 6, 2024 12:34

comment out compute budget

9779b08

chat blast: fan out server impl

bbb81ba

wip

ae9aa7c

Merge remote-tracking branch 'origin/main' into rt-targeted

de2b4a5

WIP fake targeted message chat

4150a7d

Merge branch 'dev-comment-compute-budget' into rt-targeted

5ae7f22

successful blast write to db

8343eec

add test blast message to ChatList

6ceef06

Merge branch 'main' into rt-targeted

b25a9db

working create blast

5a3e6f9

Revert "comment out compute budget"

194e636

This reverts commit 9779b08.

cleanup

8466a1c

amendelsohn requested review from dharit-tan, rickyrombo and stereosteve August 14, 2024 20:29

pull-request-size bot added the size/L label Aug 14, 2024

amendelsohn added 2 commits August 14, 2024 13:30

Merge branch 'main' into rt-targeted

fe8b607

restore TargetedMessageCTA changes

a585e90

dharit-tan reviewed Aug 14, 2024

View reviewed changes

rickyrombo approved these changes Aug 14, 2024

View reviewed changes

dharit-tan reviewed Aug 14, 2024

View reviewed changes

dharit-tan approved these changes Aug 14, 2024

View reviewed changes

amendelsohn added 2 commits August 14, 2024 13:55

PR comments

809742b

fix types & lint

ee10038

amendelsohn enabled auto-merge (squash) August 14, 2024 22:03

amendelsohn disabled auto-merge August 14, 2024 22:03

amendelsohn merged commit 83260f6 into main Aug 14, 2024

amendelsohn deleted the rt-targeted branch August 14, 2024 22:33

Create ChatBlast from web #9447

Create ChatBlast from web #9447

Uh oh!

Conversation

amendelsohn commented Aug 14, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardian bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot bot commented Aug 14, 2024 •

edited

Loading

gitguardian bot commented Aug 14, 2024 •

edited

Loading