[PAY-2917][QA-1466] Migrate more users endpoints #9308

schottra · 2024-07-30T19:50:07Z

Description

Migrates some usages of getRelatedArtists, getTopUsers, getRelatedUsers.

How Has This Been Tested?

Tested locally against staging. Used comparison utility to verify SDK output is functionally equivalent to original output.

changeset-bot · 2024-07-30T19:50:11Z

⚠️ No Changeset found

Latest commit: a8b38f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-07-30T21:40:38Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-2

* main: (82 commits) Improve useClickOutside (#9377) [PAY-2267] Update stage payment router and program addresses (#9387) [QA-1446] Fix popup alignment (#9389) Audius Protocol v0.6.164 Add priority fees to purchases (#9392) [PAY-3314] Track select dropdown for purchase/remix targeting (#9386) Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319) [C-4676] Fix es search returning deactivated content (#9382) [PAY-3331] Purchase/sale endpoint filtering by content id (#9376) cleanup audio analysis code (#9379) [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375) Fix short trending bug (#9378) [QA-1114] Include menu items even if buttons are present (#9381) [QA-875] Use size for es query to fix feed pagination bug (#9380) Audius Protocol v0.6.163 As/proto 1888 core plays (#9348) Remove audius-cmd purchase-content (#9374) [QA-1486] Fix sign up select artists screen (#9371) [PAY-3313] Targeted DMs CTA and modal (#9364) [C-4921] Fix search v2 navigating back from profile (#9370) ...

gitguardian · 2024-08-07T16:15:12Z

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11648676	Triggered	Generic High Entropy Secret	`ef6662d`	core/infra/dev_config/discovery-one.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`ef6662d`	core/infra/dev_config/content-three.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`ef6662d`	core/infra/dev_config/content-two.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`ef6662d`	core/infra/dev_config/content-one.docker.env	View secret
11648676	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/discovery-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/discovery-one.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/content-three.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/content-three.env	View secret
11648679	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/content-two.docker.env	View secret
11648679	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/content-two.env	View secret
11648680	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/content-one.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`a8b38f4`	core/infra/dev_config/content-one.env	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-07T16:29:50Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-2

audius-infra · 2024-08-07T17:10:19Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-2

…ts-round-2 * origin/main: (43 commits) Testnet configuration for cometbft core (#9421) Fix pagination args (#9425) [QA-1501] Fix mobile search input (#9426) Add paginations to comments API (#9407) [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Audius Client (Web and Mobile) v1.5.94 check is_custom_musical_key before pulling in calculated key in repairer (#9417) Set is_custom_musical_key (#9418) add is_custom_musical_key (#9416) fix repairer eager loading (#9414) [PAY-3332] Remixers users endpoint (#9401) clean up aa endpts and limit ffprobe fields (#9413) relay retries (#9410) Audius Protocol v0.6.166 [QA-1459] Fix 0087_fix_slugs_with_slash.sql migration (#9411) [QA-1491] Fix balance polling bug (#9402) Fix lint (#9412) [QA-1356] Improve notification UI (#9390) Fix useClickOutside (#9409) Add better error messages for Claimable Tokens Program (#9369) ...

audius-infra · 2024-08-13T15:06:46Z

Preview this change https://demo.audius.co/pay-2917-user-endpoints-round-2

sliptype

looking clean!

sliptype · 2024-08-13T15:38:12Z

packages/common/src/store/ui/related-artists/sagas.ts

+    const { data } = yield* call(
+      [sdk.full.users, sdk.full.users.getRelatedUsers],


I wonder if we even need the context argument anymore or if you could just do

Suggested change

const { data } = yield* call(

[sdk.full.users, sdk.full.users.getRelatedUsers],

const { data } = yield* call(

sdk.full.users.getRelatedUser,

Unfortunately I think we do because each SDK api is an instance of a class and makes copious use of this.

…ts-round-3 * origin/main: [PAY-2917][QA-1466] Migrate more users endpoints (#9308) [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Format Solana Relay listens endpoint (#9429) Add buy button metrics (#9428) Audius Protocol v0.6.167

[d712b07] [C-4939] Add comment action menu popup (#9472) JD Francis [641c9c1] [C-4940] Add comment badges (desktop web) (#9475) JD Francis [aca7b5c] [PAY-3315][PAY-3316][PAY-3323] Staking bridge (#9408) Saliou Diallo [bdc139a] [C-4828] Add timestamp features to comments (#9455) JD Francis [3457aeb] [QA-1504] Fix payout wallet set default (#9467) Raymond Jacobson [8c127d0] Add comment replies pagination (#9435) Isaac Solo [c5e250e] [C-4929] Add SendIcon component to harmony and harmony native (#9422) Kyle Shanks [a17b30e] Hook up client blast params to sdk (#9466) Reed [11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed [bcaebb0] fix TS error (#9468) JD Francis [bb802b7] Optimistic add chat blasts (#9463) Reed [b5de040] Fix bad claimable challenge state due to nullable max_steps (#9461) Randy Schott [d4c34c3] Fix comment delete in audius-query (#9462) JD Francis [95380d8] [C-4800] Scaffolding for mobile comments (#9449) Sebastian Klingler [fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott [2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed [279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins [acb857e] Fix bug in profile page 404 (#9456) Raymond Jacobson [c382e82] Don't decrypt plaintext messages (#9448) Reed [172f172] [QA-1495] Fix 404 for users (#9451) Raymond Jacobson [82ab743] [PAY-3227] Unfurl tracks in composer (#9434) Raymond Jacobson [363af71] Compose Solana Client in SDK (#9441) Marcus Pasell [83260f6] Create ChatBlast from web (#9447) Andrew Mendelsohn [19e3bdf] [PAY-3341] Add is_plaintext field for chat message (#9442) Steve Perkins [e25c679] Rename Targeted Message to Chat Blast (#9443) Reed [fc0604c] [C-4964] Comment header changes (#9444) JD Francis [f9e4525] [PAY-3310] Chat blast function in sdk (#9436) Reed [910b655] Move comments context to common (#9440) JD Francis [bb5eaa1] [C-4910] Comments replys & deletes fixes (#9437) JD Francis [1072f5a] [PAY-3106][PAY-2914] Use SDK to withdraw USDC (#9419) Marcus Pasell [1b7bd47] Add social signup feature flag (#9439) Sebastian Klingler [4130f42] Fix duplicate error name in sentry (#9430) Marcus Pasell [54a5a78] [PAY-3300] Chat blast: lazy create thread (#9424) Steve Perkins [ca71d76] [C-4910] Audius-query-ify comments state management (#9423) JD Francis [20a55e9] [PAY-2917][QA-1466] Migrate more users endpoints (#9308) Randy Schott [ab38869] [QA-1434] Fix hanging uploads due to errors on mobile (#9420) Randy Schott [f6ab71c] Add buy button metrics (#9428) Isaac Solo [06ee8a1] Fix pagination args (#9425) Isaac Solo [b91437a] [QA-1501] Fix mobile search input (#9426) Sebastian Klingler [a3c15fd] [C-4932] Add CommentBody component to harmony and harmony-native (#9415) Kyle Shanks

pull-request-size bot added the size/XL label Jul 30, 2024

schottra added 2 commits July 30, 2024 17:27

migrated related artists

c18968b

remove apiClient implementation

c23f20d

schottra force-pushed the pay-2917-user-endpoints-round-2 branch from 363d355 to c23f20d Compare July 30, 2024 21:27

pull-request-size bot added size/L and removed size/XL labels Jul 30, 2024

schottra marked this pull request as ready for review July 30, 2024 21:45

fix imports for new adapters

636c739

schottra requested a review from sliptype August 13, 2024 14:52

sliptype approved these changes Aug 13, 2024

View reviewed changes

schottra merged commit 20a55e9 into main Aug 13, 2024

schottra deleted the pay-2917-user-endpoints-round-2 branch August 13, 2024 16:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-2917][QA-1466] Migrate more users endpoints #9308

[PAY-2917][QA-1466] Migrate more users endpoints #9308

Uh oh!

schottra commented Jul 30, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 30, 2024 •

edited

Loading

Uh oh!

audius-infra commented Jul 30, 2024

Uh oh!

gitguardian bot commented Aug 7, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 7, 2024

Uh oh!

audius-infra commented Aug 7, 2024

Uh oh!

audius-infra commented Aug 13, 2024

Uh oh!

sliptype left a comment

Uh oh!

sliptype Aug 13, 2024

Uh oh!

schottra Aug 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const { data } = yield* call(
		[sdk.full.users, sdk.full.users.getRelatedUsers],

[PAY-2917][QA-1466] Migrate more users endpoints #9308

[PAY-2917][QA-1466] Migrate more users endpoints #9308

Uh oh!

Conversation

schottra commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Jul 30, 2024

Uh oh!

gitguardian bot commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Aug 7, 2024

Uh oh!

audius-infra commented Aug 7, 2024

Uh oh!

audius-infra commented Aug 13, 2024

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

sliptype Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

schottra Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

schottra commented Jul 30, 2024 •

edited

Loading

changeset-bot bot commented Jul 30, 2024 •

edited

Loading

gitguardian bot commented Aug 7, 2024 •

edited

Loading